[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-73290941 @srowen From now until we cut a 1.3.0 preview, I'd merge all bug fixes into at least master and `branch-1.3`. We'll raise the bar for getting fixes into `branch-1.3` a

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-73290045 Ah sounds like I should have done more back-porting. I was conservative and only put these several small fixes in master. Go ahead and I'll recalibrate a little accordingl

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-73289353 I've also merged this into `branch-1.3` (1.3.0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-73206257 Since this was a very simple change, I went ahead and merged it as my first test-drive of the commit bit. Looks like it worked! --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-02-03 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-72786951 I wonder if stopping the process is the best solution. If there is only one illegal entry in a last line, we need to re-try loading a whole file, which is time-cons

[GitHub] spark pull request: [SPARK-5380][GraphX] Solve an ArrayIndexOutOfB...

2015-01-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4176#issuecomment-71170456 The argument I can see against it is simply that you want to fail fast on bad input, not sort of continue. If all of the file is like this you'll just log a zillion warnin