[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-02-27 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-76402017 Since the commit this depends on was in 1.2 (https://github.com/apache/spark/commit/1f8b7186813643afdb592131bfd89228ef971e74) and this was tagged for back-port into 1.2, a

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71928894 No, only as of #4194. After I merged that I realized we still set it elsewhere redundantly but didn't really get to removing it myself. --- If your project is set up

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-28 Thread ryan-williams
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71920785 thanks @andrewor14, to be clear, afaik the removed line here only became redundant on Sunday with #4194; did you mean you've been wanting to do the same since then?

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71915225 LGTM I've been wanting to do the same merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71580340 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71580332 [Test build #26132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26132/consoleFull) for PR 4213 at commit [`b3e4f7b`](https://gith

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4213#issuecomment-71574203 [Test build #26132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26132/consoleFull) for PR 4213 at commit [`b3e4f7b`](https://githu

[GitHub] spark pull request: [SPARK-5417] Remove redundant executor-id set(...

2015-01-26 Thread ryan-williams
GitHub user ryan-williams opened a pull request: https://github.com/apache/spark/pull/4213 [SPARK-5417] Remove redundant executor-id set() call This happens inside SparkEnv initialization as of #4194 You can merge this pull request into a Git repository by running: $ git pull h