[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-87333746 @pwoody @mccheah any update on it? If you saw an error, what was the exception and error message? --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76842442 @mccheah we [set the serializer in SQL on a per-shuffle basis](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76840419 Talked with @pwoody offline and he's working on a test case, but I'll summarize what I think will break. If you use an SQL Context wrapping a Spark Context where you set

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76764601 @pwoody I don't think that is possible. As long as the two sides are using copies of kryo with the same order or registration then things should work. As far as I know

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread pwoody
Github user pwoody commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76708974 I believe the bug is due to inconsistency between KryoSerializer and SqlSerializer in the order of registration. I don't know if there is a way to manage multiple Serializ

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75130162 There is no reason to allow custom kryo registration. The SQL serializer is only ever used to serialize SQL types. Have you seen some bug with us missing a type? ---

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75089655 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75089643 [Test build #27723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27723/consoleFull) for PR 4693 at commit [`8e756cc`](https://gith

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75081171 [Test build #27723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27723/consoleFull) for PR 4693 at commit [`8e756cc`](https://githu

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread ash211
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75080190 Jenkins this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-75075748 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-02-19 Thread hkothari
GitHub user hkothari opened a pull request: https://github.com/apache/spark/pull/4693 [SPARK-5494][SQL] SparkSqlSerializer Ignores KryoRegistrators SparkSqlSerializer completely ignores custom KryoRegistrators (unlike the regular Spark serializer). I've applied a change to call supe