[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-25 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-86267268 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-18 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82926819 Hi, @marmbrus ,I had update the code as you mentioned about. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82742868 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82742847 [Test build #28768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28768/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82728164 [Test build #28768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28768/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82720472 Minor comments otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/4289#discussion_r26635881 --- Diff: sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim12.scala --- @@ -189,7 +189,7 @@ private[hive] object HiveShim { def

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/4289#discussion_r26635872 --- Diff: sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim12.scala --- @@ -244,6 +244,11 @@ private[hive] object HiveShim { }

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-17 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-82383269 Updated, @marmbrus @chenghao-intel . We had tested this patch in our environment over the past few days.Any more problems in this patch? --- If your project is set up

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78931260 [Test build #28561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28561/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78959734 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78959709 [Test build #28561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28561/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78578574 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78578548 [Test build #28532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28532/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-78574020 [Test build #28532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28532/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-11 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73868381 @chenghao-intel ,I had pass all unit test in my local .But i think the unit test of thrift-server seems unstable,it's depend on the state of the machine,when the machine

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-11 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73877412 /cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73828057 [Test build #27267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27267/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73830591 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73830587 [Test build #27267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27267/consoleFull) for PR 4289 at commit

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73837462 Hi,@marmbrus , @chenghao-intel I have no idea why `SPARK-4407 regression: Complex type support` this test failed after i resolved the merge conflicts.It seems that not

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73838104 @jeanlyn The HiveThriftServer unit test was disable previously before #4486 merged. From the log it's hard to say the failure reason, can you try it in you local?

[GitHub] spark pull request: [SPARK-5498][SQL]fix query exception when part...

2015-02-10 Thread jeanlyn
Github user jeanlyn commented on the pull request: https://github.com/apache/spark/pull/4289#issuecomment-73836885 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this