Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4412
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73738745
OK, that's looking good to me. I'll pause shortly to let others review it
too.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73701313
[Test build #27200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27200/consoleFull)
for PR 4412 at commit
[`fbbc785`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73701317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73691995
[Test build #27200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27200/consoleFull)
for PR 4412 at commit
[`fbbc785`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73690234
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73690222
[Test build #27199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27199/consoleFull)
for PR 4412 at commit
[`b968e14`](https://gith
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73682144
@srowen thank you, please help to check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24404265
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -50,6 +50,15 @@ private[spark] class HttpFileServer(
def stop() {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73681631
[Test build #27199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27199/consoleFull)
for PR 4412 at commit
[`b968e14`](https://githu
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24399228
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -76,6 +76,8 @@ class SparkEnv (
// (e.g., HadoopFileRDD uses this to cache JobConfs
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24399263
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -367,6 +385,13 @@ object SparkEnv extends Logging {
metricsSystem,
sh
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24399179
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -50,6 +50,15 @@ private[spark] class HttpFileServer(
def stop() {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73663218
[Test build #27186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27186/consoleFull)
for PR 4412 at commit
[`1339c96`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73663224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user Sephiroth-Lin commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73655978
@srowen thank you, now I add a member to store the reference of the tmp dir
if it was created, please help to check again.
---
If your project is set up for it, yo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73655674
[Test build #27186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27186/consoleFull)
for PR 4412 at commit
[`1339c96`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73501847
[Test build #27097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27097/consoleFull)
for PR 4412 at commit
[`b2018a5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73501855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73493147
[Test build #27097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27097/consoleFull)
for PR 4412 at commit
[`b2018a5`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4412#issuecomment-73492548
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24316626
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,19 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24306573
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,19 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24305906
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,19 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24305832
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,19 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24285284
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,14 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24289455
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,19 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24267365
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,14 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24246142
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -93,6 +93,14 @@ class SparkEnv (
// actorSystem.awaitTermination()
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4412#discussion_r24245999
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -50,6 +50,15 @@ private[spark] class HttpFileServer(
def stop() {
30 matches
Mail list logo
