Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77522081
I wasn't expecting this to be closed. Although parts of the changes didn't
seem particularly useful, I believe the changes in `ExternalSorter` could
potentially lead t
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77407789
I am sorry, the comments are valid. I am closing this PR. Thank you for
reviewing it.
---
If your project is set up for it, you can reply to this email and have your
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/4878
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25821421
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala
---
@@ -68,7 +68,7 @@ private[spark] class FileSystemPer
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25821370
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -106,7 +106,7 @@ class IndexShuffleBlockManager(conf: Spark
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77264094
Sorry to chime in late, but have you done performance tests with this to
see if it makes a difference? There two issues I see here:
(1) This isn't the plac
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25748317
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -721,13 +721,13 @@ private[spark] class ExternalSorter[K, V, C](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25747285
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala
---
@@ -58,7 +58,7 @@ private[spark] class FileSystemPersis
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77083944
LGTM pending @srowen's comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77025584
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77025569
[Test build #28236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28236/consoleFull)
for PR 4878 at commit
[`c7a739e`](https://gith
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25714850
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala
---
@@ -58,7 +58,7 @@ private[spark] class FileSystemPersistenc
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4878#issuecomment-77009074
[Test build #28236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28236/consoleFull)
for PR 4878 at commit
[`c7a739e`](https://githu
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/4878
[SPARK-5920][CORE]BufferedInputStream is added at required places
BufferedInputStream and BufferedOutputStream is added at required places.
You can merge this pull request into a Git repository b
14 matches
Mail list logo
