[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91708484 Make sense, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91707978 I've cherry-picked the fix into `branch-1.2` (1.2.3) and `branch-1.3` (1.3.2). I'm going to omit the the pre-1.2 backports for now because I hit a test merge conflict

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91695334 This is a bug since the beginning (0.8), could we back port it for all 1.0+ branches? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91685310 Should this be backported anywhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91682313 Alright, merging this into `master` (1.4.0) now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91057061 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-04-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-91055024 @davies, does this look good to you? Sorry for letting this patch fall off my radar (slowly getting caught up on a backlog of reviews). If things look good, I can fix

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-77534561 [Test build #28334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28334/consoleFull) for PR 4761 at commit [`95896b5`](https://gith

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-77534574 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-77524723 [Test build #28334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28334/consoleFull) for PR 4761 at commit [`95896b5`](https://githu

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-06 Thread foxik
Github user foxik commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-77524291 I have amended the regression test commit to pass lint-python. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-04 Thread foxik
Github user foxik commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-77315278 I added the regression test. It also tests that sortByKey returns sorted sequence and tests also ascending sequence, which are not strictly necessary for SPARK-5969, but I

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-03-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-76869836 Could you add a regression test for this issue? It looks like you have one in the JIRA ticket, so adding one hopefully should not be much work. Take a look at `python

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4761#issuecomment-75915815 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-5969][PySpark] Fix descending pyspark.r...

2015-02-24 Thread foxik
GitHub user foxik opened a pull request: https://github.com/apache/spark/pull/4761 [SPARK-5969][PySpark] Fix descending pyspark.rdd.sortByKey. The samples should always be sorted in ascending order, because bisect.bisect_left is used on it. The reverse order of the result is already