Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-86179649
Merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-85812116
[Test build #29137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29137/consoleFull)
for PR 4827 at commit
[`7d25545`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-85812132
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27092730
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -170,8 +170,8 @@ class BlockManagerSuite extends FunSuite with Matche
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27091991
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -170,8 +170,8 @@ class BlockManagerSuite extends FunSuite with Matchers
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-85800659
LGTM. I will merge this once tests pass thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27091788
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -170,8 +170,8 @@ class BlockManagerSuite extends FunSuite with Matche
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27091751
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -317,6 +337,29 @@ private[spark] class MemoryStore(blockManager:
BlockManag
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-85784928
[Test build #29137 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29137/consoleFull)
for PR 4827 at commit
[`7d25545`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-85740521
Thanks @zsxwing I left one more code style comment and I think it's ready
after that.
---
If your project is set up for it, you can reply to this email and have your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27083960
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -97,11 +117,11 @@ private[spark] class MemoryStore(blockManager:
BlockManag
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84809868
[Test build #28976 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28976/consoleFull)
for PR 4827 at commit
[`1100a54`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84809871
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84779443
[Test build #28976 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28976/consoleFull)
for PR 4827 at commit
[`1100a54`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84779395
@andrewor14 I updated to use `() => T`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84238397
@andrewor14 is it acceptable that changing call-by-name to `() => Unit`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-84128164
@zsxwing the approach looks reasonable. I'm wondering if there's a more
readable way to do the same thing. In particular, currently this uses
call-by-name (`tryToPut`,
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r26870986
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -535,9 +535,10 @@ private[spark] class BlockManager(
/*
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-83769366
Sorry for the delay. I was away for a little more than a week and I will
look at this later today.
---
If your project is set up for it, you can reply to this email a
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-82703473
CC @andrewor14 again in case it was missed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-76681216
CC @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-76516447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-76516442
[Test build #28118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28118/consoleFull)
for PR 4827 at commit
[`0cc0257`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4827#issuecomment-76514362
[Test build #28118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28118/consoleFull)
for PR 4827 at commit
[`0cc0257`](https://githu
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/4827
[SPARK-6076][Block Manager] Fix a potential OOM issue when StorageLevel is
MEMORY_AND_DISK_SER
In
https://github.com/apache/spark/blob/dcd1e42d6b6ac08d2c0736bf61a15f515a1f222b/core/src/main/scala/o
26 matches
Mail list logo
