[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread liyezhang556520
Github user liyezhang556520 closed the pull request at: https://github.com/apache/spark/pull/4829 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76568676 sure, I'll close this PR then, thanks for your review @JoshRosen, @srowen @andrewor14 --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76538499 Yes, we purposefully removed this feature. @liyezhang556520 would you mind closing this? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76529284 FWIW I think the reasoning at https://github.com/apache/spark/pull/4120#issuecomment-72954989 still stands and so we should also close this PR + JIRA as a duplicate. ---

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516881 [Test build #28120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28120/consoleFull) for PR 4829 at commit [`e76a1b4`](https://gith

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516882 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516587 @srowen @vanzin @andrewor14, what are your thoughts on the usability / security trade-offs here? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-28 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516507 Hi @JoshRosen, it's duplicate with https://issues.apache.org/jira/browse/SPARK-5311, now that it won't fix, should I also close this PR? But it is really no

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516211 If we do decide to create directories, then we should only create the last missing directory, not all missing parent directories. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-27 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76516159 This looks like a duplicate of #4120 / https://issues.apache.org/jira/browse/SPARK-5311, which we marked as "Won't Fix": https://github.com/apache/spark/pull/4120#issue

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4829#issuecomment-76514752 [Test build #28120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28120/consoleFull) for PR 4829 at commit [`e76a1b4`](https://githu

[GitHub] spark pull request: [SPARK-6078][CORE] create event log dir if not...

2015-02-27 Thread liyezhang556520
GitHub user liyezhang556520 opened a pull request: https://github.com/apache/spark/pull/4829 [SPARK-6078][CORE] create event log dir if not exists when event log directory does not exists, spark just throw IlleagalArgumentException and stop the job. User need manually create directo