[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-28 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-97048856 @srowen may i got some idea about why we need to try to cache twice: if a shuffleRDD need to be cached, and level is memory&disk&serial, so when first try,only can

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-28 Thread suyanNone
Github user suyanNone closed the pull request at: https://github.com/apache/spark/pull/4886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-19 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-94342126 @srowen I fine to close this patch. eh...I not sure I fully got your point. I agree this means "a level which does not use memory" and ` This branch is for the case

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-94252029 Do you mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-93945173 No, it means "a level which does not use memory". This branch is for the case where you do not put in memory. I don't think this addresses the overall comment before, or t

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-17 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-93885511 @srowen I forgot to update desc, already refine if program go here `if (!putLevel.useMemory) {`, means put a disk level block, or memory_and_disk level bl

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-93378547 @suyanNone from the description I'm still not sure I understand why this is needed. It seems reasonable to try again to put the data into memory, later, if it is intended

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-92764219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-92764195 [Test build #30240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30240/consoleFull) for PR 4886 at commit [`5be306e`](https://gith

[GitHub] spark pull request: [SPARK-6156][CORE]Not cache in memory again wh...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4886#issuecomment-92710924 [Test build #30240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30240/consoleFull) for PR 4886 at commit [`5be306e`](https://githu