Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-86289291
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-85044321
There is one of mapjoin_addjar, and I'll add that after I refactor #4586
. So I'd like this one merge first, thanks a lot!
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84875097
[Test build #28981 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28981/consoleFull)
for PR 4930 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84875142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-85025856
LGTM. Is there any Hive query test that we should enable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84844091
[Test build #28982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28982/consoleFull)
for PR 4930 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84843466
[Test build #28981 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28981/consoleFull)
for PR 4930 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84876719
[Test build #28982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28982/consoleFull)
for PR 4930 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84876740
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-84372350
ping @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4930#discussion_r26811257
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -151,7 +152,15 @@ class TestHiveContext(sc: SparkContext)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-83902878
[Test build #28905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28905/consoleFull)
for PR 4930 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-83869794
[Test build #28905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28905/consoleFull)
for PR 4930 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-83902884
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4930#discussion_r26808679
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -151,7 +152,15 @@ class TestHiveContext(sc: SparkContext) extends
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4930#discussion_r26731166
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -151,7 +152,15 @@ class TestHiveContext(sc: SparkContext) extends
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4930#discussion_r26640654
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -151,7 +152,15 @@ class TestHiveContext(sc: SparkContext) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82779709
[Test build #28775 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28775/consoleFull)
for PR 4930 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82779728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82492629
Also, add a comment in the code to explain the reason will be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82492375
Can you explain the reason that you need to do the change when we already
have substitution in `HiveContext.sql`?
---
If your project is set up for it, you can reply to
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82746886
we should substitute variables in hql to pass the text to parseSql() as a
parameter. Hive parser need substituted text. HiveContext.sql() does this but
return a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-82746939
[Test build #28775 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28775/consoleFull)
for PR 4930 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4930#discussion_r26639926
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -151,7 +152,15 @@ class TestHiveContext(sc: SparkContext) extends
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-77787040
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-77533722
[Test build #28333 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28333/consoleFull)
for PR 4930 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-77533732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/4930
[SPARK-6202] [SQL] enable variable substitution on test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adrian-wang/spark testvs
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4930#issuecomment-77524741
[Test build #28333 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28333/consoleFull)
for PR 4930 at commit
30 matches
Mail list logo
