Github user MechCoder closed the pull request at:
https://github.com/apache/spark/pull/5081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113606205
[Test build #35305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35305/console)
for PR 5081 at commit
[`7f46d17`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113606228
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113603749
[Test build #35305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35305/consoleFull)
for PR 5081 at commit
[`7f46d17`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113602874
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113602841
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113601601
should be fixed now. retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113600504
Yep, we're fixing it now via a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113599173
There seems to be a unrelated whitespace error in L30 in
`/spark/examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala`
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113598811
[Test build #35303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35303/console)
for PR 5081 at commit
[`7f46d17`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113598817
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113598444
[Test build #35303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35303/consoleFull)
for PR 5081 at commit
[`7f46d17`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113598268
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113598255
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113594298
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113594291
[Test build #35299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35299/console)
for PR 5081 at commit
[`9d29561`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113592842
[Test build #35299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35299/consoleFull)
for PR 5081 at commit
[`9d29561`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113592150
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113592121
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r32833024
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113522900
@mengxr Please have a look at https://github.com/apache/spark/pull/6904/
This will help in ruling out some cases with minimum code repetition.
---
If your project is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113430091
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113430085
[Test build #35250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35250/console)
for PR 5081 at commit
[`e6b4cc5`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113429853
[Test build #35250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35250/consoleFull)
for PR 5081 at commit
[`e6b4cc5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113429742
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113429725
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113428460
Please do not. We just had a discussion about this yesterday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-113321179
@mengxr @MechCoder what is the status on this PR? It seems to fairly
outdated at this point. Should we move forward or close it?
---
If your project is set up for it
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-96770049
[Test build #31050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31050/consoleFull)
for PR 5081 at commit
[`bf0e0e7`](https://githu
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-83090015
Done already :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-83085762
Okay, let's keep this PR open and could you update the MatrixUDT PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26667455
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82989689
I'm starting to think we should just test if `.toArray` is equal and this
PR might be overkill if it is just for testing purposes.
---
If your project is set up for it
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82986299
@srowen There are two approaches:
1. implement hashCode/equals
2. use the default implementation and use toArray to compare matrices in
unit tests
Whi
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664243
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664031
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664036
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664042
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664038
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5081#discussion_r26664035
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -100,6 +100,50 @@ sealed trait Matrix extends Serializable {
*
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82979809
The hashCode implementation was taken from Effective Java:
http://stackoverflow.com/questions/10915309/need-explanation-for-hashcode-example-in-effective-java-textbook
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82901714
Yes, I required it in this PR https://github.com/apache/spark/pull/5048/ to
test that the matrices after serializing and deserializing are the same. (Also
given the fac
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82897129
What's the use case for comparing matrices for equality? I think it's rarer
than for vectors. Is it just for testing, mostly?
---
If your project is set up for it, you ca
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82846862
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82846851
[Test build #28785 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28785/consoleFull)
for PR 5081 at commit
[`bf0e0e7`](https://gith
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82822725
Also, I'm not sure what the failed tests are about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82812618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82812607
[Test build #28783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28783/consoleFull)
for PR 5081 at commit
[`b5033b5`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82811729
[Test build #28785 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28785/consoleFull)
for PR 5081 at commit
[`bf0e0e7`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82808894
[Test build #28781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28781/consoleFull)
for PR 5081 at commit
[`4041b59`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82808948
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82782728
[Test build #28783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28783/consoleFull)
for PR 5081 at commit
[`b5033b5`](https://githu
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82780115
@mengxr
1. Is there any reason why `forEachActive` is private? It took me some time
to realize that it existed (and I already wrote my implementation by then)
2.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82778608
cc @mengxr . Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5081#issuecomment-82779020
[Test build #28781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28781/consoleFull)
for PR 5081 at commit
[`4041b59`](https://githu
GitHub user MechCoder opened a pull request:
https://github.com/apache/spark/pull/5081
[SPARK-6364] [MLlib] Implement equals and hashcode for Matrix
Implementing methods equals hashcode and equals for Matrix
You can merge this pull request into a Git repository by running:
$ gi
56 matches
Mail list logo
