Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-165277966
Thank you for merging it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-165210239
LGTM, merging with master and branch-1.6
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164995759
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164995760
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164995674
**[Test build #47780 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47780/consoleFull)**
for PR 9952 at commit
[`3066696`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164967000
**[Test build #47780 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47780/consoleFull)**
for PR 9952 at commit
[`3066696`](https://gith
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164966445
@jkbradley thanks for the review. I modified the wrong indentations and
excluded the import statements for `SparkConf` and `JavaSparkContext`.
---
If your project is se
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164932852
The generated docs look good, so just those few comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164926967
No problem. I just added some comments and am generating the docs now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9952#discussion_r47712644
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaBisectingKMeansExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apach
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9952#discussion_r47712602
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaBisectingKMeansExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apach
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9952#discussion_r47712606
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaBisectingKMeansExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apach
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164343732
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164343734
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164343681
**[Test build #47639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47639/consoleFull)**
for PR 9952 at commit
[`7c36c1d`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164342390
**[Test build #47639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47639/consoleFull)**
for PR 9952 at commit
[`7c36c1d`](https://gith
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-164341602
Oh, I'm terribly sorry about that. Pushing the update was failed
- Modified what you pointed out
- Add a Java example and its doc
---
If your project is set
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-163707596
@yu-iskw There are several comments of mine (above) which have not yet been
addressed. Could you please update this PR based on those comments? I'll then
take anothe
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-163487878
ping @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-162721817
Thanks, I'll check back for updates for the few remaining comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/9952#issuecomment-162698533
@jkbradley sure, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
22 matches
Mail list logo
