[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-07 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90794257 I'll go ahead and merge this with master. Thanks @oefirouz ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90230345 I'm going to say no; that sounds like an extra option we could add later. More details on that API: * Our current API: Either fit the intercept, or fix it at 0. Do

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-06 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90226337 One comment before we merge this: Is it useful to specify the bias constant? In LIBLINEAR, there is an option called `-B bias`. If `bias == 0`, we don't add intercept, oth

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90197331 [Test build #636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/636/consoleFull) for PR 5301 at commit [`9f1286b`](https://githu

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90167243 LGTM once the full tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-90165363 [Test build #636 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/636/consoleFull) for PR 5301 at commit [`9f1286b`](https://github

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-89516868 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29

[GitHub] spark pull request: [SPARK-6705][MLLIB] Add fit intercept api to m...

2015-04-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5301#issuecomment-89516426 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl