Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-150612720
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149742039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149742038
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149741952
**[Test build #44016 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44016/consoleFull)**
for PR 6785 at commit
[`e97930c`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149735051
**[Test build #44016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44016/consoleFull)**
for PR 6785 at commit
[`e97930c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149734516
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149734446
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-149733096
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user jayantshekhar commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41457582
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -102,6 +110,66 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-146163905
LGTM overall, some nits, ping @mengxr to trigger tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41379676
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -102,6 +110,66 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41379557
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -102,6 +110,66 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41379495
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -102,6 +110,66 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41379475
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -102,6 +110,66 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r41379404
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -19,11 +19,19 @@ package org.apache.spark.mllib.feature
Github user jayantshekhar commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-145231160
Thanks Feyman!
Cleaned up the newlines and fixed the merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-134419255
Can you fix merge conflicts so I can try it out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r37819171
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/ChiSqSelectorSuite.scala ---
@@ -63,4 +64,35 @@ class ChiSqSelectorSuite extends SparkFunSu
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r37819138
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -99,6 +107,66 @@ class ChiSqSelectorModel (val selectedFeatures:
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6785#discussion_r37818567
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -99,6 +107,66 @@ class ChiSqSelectorModel (val selectedFeatures:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6785#issuecomment-111570756
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user jayantshekhar opened a pull request:
https://github.com/apache/spark/pull/6785
[SPARK-6723] [MLLIB] Model import/export for ChiSqSelector
This is a PR for Parquet-based model import/export.
* Added save/load for ChiSqSelectorModel
* Updated the test suite Chi
23 matches
Mail list logo
