Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101579067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101579066
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101579055
[Test build #32593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32593/consoleFull)
for PR 5383 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101728815
Thanks for working on this! Merging to master and branch-1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r30246138
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,15 @@ import org.apache.spark.annotation.DeveloperApi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101541080
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101541044
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-101541488
[Test build #32593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32593/consoleFull)
for PR 5383 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-96516549
@liancheng @marmbrus Any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95610869
[Test build #30845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30845/consoleFull)
for PR 5383 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95628566
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95628553
[Test build #30845 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30845/consoleFull)
for PR 5383 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95765126
[Test build #30890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30890/consoleFull)
for PR 5383 at commit
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r29021010
--- Diff: sql/hive/src/test/resources/golden/Test UDTF.close in Lateral
Views-0-ac5c96224a534f07b49462ad76620678 ---
@@ -0,0 +1,2 @@
+97 500
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95779193
[Test build #30890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30890/consoleFull)
for PR 5383 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95779198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-95782798
cc @liancheng @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28828949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,16 @@ import org.apache.spark.annotation.DeveloperApi
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28829143
--- Diff: sql/hive/src/test/resources/golden/Test UDTF.close in Lateral
Views-0-ac5c96224a534f07b49462ad76620678 ---
@@ -0,0 +1,2 @@
+97 500
+97 500
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-94633296
[Test build #30620 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30620/consoleFull)
for PR 5383 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-94633301
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28745931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,15 @@ import org.apache.spark.annotation.DeveloperApi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28305846
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -71,6 +71,12 @@ abstract class Generator extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28310316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -56,28 +65,33 @@ case class Generate(
val boundGenerator =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28310315
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,15 @@ import org.apache.spark.annotation.DeveloperApi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28306055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -56,28 +65,33 @@ case class Generate(
val boundGenerator =
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28305660
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -52,14 +56,32 @@ class HiveQuerySuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28305665
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -36,6 +39,7 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92501509
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92501504
[Test build #30195 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30195/consoleFull)
for PR 5383 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92500634
[Test build #30195 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30195/consoleFull)
for PR 5383 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92520820
[Test build #30202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30202/consoleFull)
for PR 5383 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92543221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92543213
[Test build #30202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30202/consoleFull)
for PR 5383 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92544533
Thank you @liancheng I've updated the code and it passed the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28214577
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28212494
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205759
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205652
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -71,6 +71,12 @@ abstract class Generator extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205769
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-92097125
Please also add a test case to test the case where `Generator.join` is true.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205580
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205574
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28205711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -75,9 +78,15 @@ case class Generate(
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-91172886
I found one issue; the current implementation of HiveGenericUdtf always
calls `terminate()` though, it does not call `initialize()` in some cases
because of lazy
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-91317211
[Test build #29954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29954/consoleFull)
for PR 5383 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-91316943
@maropu thanks for the comments, I've updated the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-91342733
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r27982781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -74,10 +84,15 @@ case class Generate(
} else {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r27995414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -74,10 +84,15 @@ case class Generate(
} else {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r27861265
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -74,10 +84,15 @@ case class Generate(
} else {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-90379070
[Test build #29778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29778/consoleFull)
for PR 5383 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-90379100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r27897916
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -74,10 +84,15 @@ case class Generate(
} else {
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/5383
[SPARK-6734] [SQL] Add UDTF.close support in Generate
Some third-party UDTF extensions generate additional rows in the
GenericUDTF.close() method, which is supported / documented by Hive.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5383#issuecomment-90356260
[Test build #29778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29778/consoleFull)
for PR 5383 at commit
57 matches
Mail list logo
