[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93491077 [Test build #30357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30357/consoleFull) for PR 5499 at commit

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93528614 [Test build #30357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30357/consoleFull) for PR 5499 at commit

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93528652 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93550520 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-14 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93120923 I will add a test in `InMemoryColumnarQuerySuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-93123075 Good catch! The change LGTM. `NullableColumnBuilderSuite` uses a mock builder because the real builders also mix in `CompressibleColumnBuilder`, while

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-92515928 [Test build #30199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30199/consoleFull) for PR 5499 at commit

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-13 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/5499 [SPARK-6887][SQL] ColumnBuilder misses FloatType https://issues.apache.org/jira/browse/SPARK-6887 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-13 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-92515941 @liancheng Where should I add the test? At first, I thought `NullableColumnBuilderSuite` is the place But, why `NullableColumnBuilderSuite` does not really use those real

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-92537454 [Test build #30199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30199/consoleFull) for PR 5499 at commit

[GitHub] spark pull request: [SPARK-6887][SQL] ColumnBuilder misses FloatTy...

2015-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5499#issuecomment-92537484 Test PASSed. Refer to this link for build results (access rights to CI server needed):