[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel closed the pull request at: https://github.com/apache/spark/pull/5798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel closed the pull request at: https://github.com/apache/spark/pull/6110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-103282541 I am not sure why we use the Map[Expression, NamedExpression] in `patterns.scala`, seems `Seq[(Expression, NamedExpression)] is more reasonable, which is definite

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-103179196 @chenghao-intel, a single method seems easier to maintain then full Map/Set implementations. I'll add that its not clear to me the use in patterns is actually invalid.

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-18 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6173#discussion_r30537865 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -76,6 +76,19 @@ abstract class Expression extends Tr

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-17 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102785381 Thank you @cloud-fan for doing this, and I think this can work as a workaround for cases like `Seq[Expression].find`, however, there are still cases like `Map[Exp

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102576539 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102576536 [Test build #32882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32882/consoleFull) for PR 6173 at commit [`e4a3cc7`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102576540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102570084 [Test build #32882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32882/consoleFull) for PR 6173 at commit [`e4a3cc7`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102570041 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102570039 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6173#discussion_r30435449 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -76,6 +76,15 @@ abstract class Expression extends Tr

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6173#discussion_r30435480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -148,17 +147,17 @@ class Analyzer( * @param exp

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102320320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102320319 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102320314 [Test build #32785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32785/consoleFull) for PR 6173 at commit [`cc02045`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102307003 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102306967 [Test build #32779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32779/consoleFull) for PR 6173 at commit [`d7ff8f4`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102307000 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102286749 Hi @chenghao-intel , as far as I know, we can only instantiate leaf expressions which are all case classes. So probably we can design the `semanticEquals` as how case

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102286472 [Test build #32785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32785/consoleFull) for PR 6173 at commit [`cc02045`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102285753 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102285817 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6173#discussion_r30387349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -76,6 +76,12 @@ abstract class Expression exte

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6173#discussion_r30387287 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -76,6 +76,12 @@ abstract class Expression exte

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102272309 [Test build #32779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32779/consoleFull) for PR 6173 at commit [`d7ff8f4`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102271340 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102271389 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6173#issuecomment-102270319 cc @chenghao-intel @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/6173 [SPARK-7269] [SQL] Incorrect analysis for aggregation(use semanticEquals) A modified version of https://github.com/apache/spark/pull/6110, use `semanticEquals` to make it more efficient. You can

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6110#discussion_r30377329 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -198,10 +198,12 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6110#discussion_r30321573 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -198,10 +198,12 @@ class Analyzer( g.bi

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-102008253 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-102008252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-102008241 [Test build #32701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32701/consoleFull) for PR 6110 at commit [`5c2162e`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101984026 [Test build #32701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32701/consoleFull) for PR 6110 at commit [`5c2162e`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101983975 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101983959 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-14 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101983821 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101540461 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101540434 [Test build #32588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32588/consoleFull) for PR 6110 at commit [`5c2162e`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101540466 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101522787 [Test build #32588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32588/consoleFull) for PR 6110 at commit [`5c2162e`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101522115 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6110#issuecomment-101522063 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101521445 I've updated the code at #6110, but I don't think that's a better solution. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/6110 [SPARK-7269] [SQL] Incorrect analysis for aggregation (new implementation) This is another implementation other than #5798 You can merge this pull request into a Git repository by running:

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101493450 OK, let's targeting the bug fixing for now, I will update the code soon. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101373181 Using `.find` seems like a pretty reasonable solution to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101216002 Hmm...How about using `Set.find` here instead of `contains`? `find` is slower than `contains` but we don't care much about performance here, right? --- If your projec

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101130145 `Set.contains` only support the concrete object parameter, not a function. Supporting the `semanticEquals` will impact lots of `Expression`s, and still we cou

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101128074 How about adding `semanticEquals` method to `Expression` like you suggested before? And we can choose `semanticEquals` as equality function for `Set.contains` etc. whe

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101109983 Thank you @marmbrus for the explanation. I was thinking if there is a simple way to make the `Expression` more like a general class, which can be used with commo

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101089451 If you break equality you will break the `transform` function. You can't stop people from using expression equality incorrectly, but you also can't stop them fr

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101081212 Will it be simpler if we refactor the `AttributeReference` that not to compare the `nullable`, `dataType` or `name`, but `exprId`? If in that case, then we might

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-101067933 The QA phase is not a reason to rush this patch in half finished. This isn't a regression and there is a trivial workaround (use consistent capitalization). I

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100792901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100792883 [Test build #32374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32374/consoleFull) for PR 5798 at commit [`e00d0bc`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100792898 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100767572 [Test build #32374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32374/consoleFull) for PR 5798 at commit [`e00d0bc`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100767191 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100767199 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100767039 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100764345 **[Test build #32361 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32361/consoleFull)** for PR 5798 at commit [`e00d0bc`](https://gi

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100764355 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100764353 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100739964 [Test build #32361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32361/consoleFull) for PR 5798 at commit [`e00d0bc`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100739850 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100739846 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5798#discussion_r30010033 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -159,18 +170,16 @@ object PartialAggregation {

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100666817 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100666814 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100666811 [Test build #32348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32348/consoleFull) for PR 5798 at commit [`24347ff`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100664819 [Test build #32348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32348/consoleFull) for PR 5798 at commit [`24347ff`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100664665 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100664631 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100654519 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100654524 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100654485 [Test build #32341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32341/consoleFull) for PR 5798 at commit [`092fdd2`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100653041 [Test build #32341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32341/consoleFull) for PR 5798 at commit [`092fdd2`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100652969 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100652961 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100650212 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100650194 [Test build #32340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32340/consoleFull) for PR 5798 at commit [`55fef69`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100650213 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100648889 Thank you @cloud-fan & @marmbrus for the suggestion, I added 2 additional classes `ExpressionSet` and `ExpressionMap`, since now is in the QA stage, I am not goin

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100647063 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100647075 [Test build #32340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32340/consoleFull) for PR 5798 at commit [`55fef69`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100647054 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5798#discussion_r29994765 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala --- @@ -77,4 +77,29 @@ package object expressions {

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5798#discussion_r29994732 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala --- @@ -77,4 +77,29 @@ package object expressions {

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100519451 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100519447 [Test build #32304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32304/consoleFull) for PR 5798 at commit [`04cd335`](https://git

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100519453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100506153 [Test build #32304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32304/consoleFull) for PR 5798 at commit [`04cd335`](https://gith

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100506135 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5798#issuecomment-100506126 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7269] [SQL] Incorrect analysis for aggr...

2015-05-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/5798#discussion_r29587194 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -137,30 +137,30 @@ object PartialAggregation {

  1   2   >