Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/5798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/6110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-103282541
I am not sure why we use the Map[Expression, NamedExpression] in
`patterns.scala`, seems `Seq[(Expression, NamedExpression)] is more reasonable,
which is definite
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-103179196
@chenghao-intel, a single method seems easier to maintain then full Map/Set
implementations. I'll add that its not clear to me the use in patterns is
actually invalid.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6173#discussion_r30537865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -76,6 +76,19 @@ abstract class Expression extends Tr
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102785381
Thank you @cloud-fan for doing this, and I think this can work as a
workaround for cases like `Seq[Expression].find`, however, there are still
cases like `Map[Exp
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102576539
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102576536
[Test build #32882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32882/consoleFull)
for PR 6173 at commit
[`e4a3cc7`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102576540
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102570084
[Test build #32882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32882/consoleFull)
for PR 6173 at commit
[`e4a3cc7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102570041
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102570039
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6173#discussion_r30435449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -76,6 +76,15 @@ abstract class Expression extends Tr
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6173#discussion_r30435480
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -148,17 +147,17 @@ class Analyzer(
* @param exp
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102320320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102320319
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102320314
[Test build #32785 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32785/consoleFull)
for PR 6173 at commit
[`cc02045`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102307003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102306967
[Test build #32779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32779/consoleFull)
for PR 6173 at commit
[`d7ff8f4`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102307000
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102286749
Hi @chenghao-intel , as far as I know, we can only instantiate leaf
expressions which are all case classes. So probably we can design the
`semanticEquals` as how case
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102286472
[Test build #32785 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32785/consoleFull)
for PR 6173 at commit
[`cc02045`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102285753
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102285817
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6173#discussion_r30387349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -76,6 +76,12 @@ abstract class Expression exte
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6173#discussion_r30387287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -76,6 +76,12 @@ abstract class Expression exte
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102272309
[Test build #32779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32779/consoleFull)
for PR 6173 at commit
[`d7ff8f4`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102271340
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102271389
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/6173#issuecomment-102270319
cc @chenghao-intel @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/6173
[SPARK-7269] [SQL] Incorrect analysis for aggregation(use semanticEquals)
A modified version of https://github.com/apache/spark/pull/6110, use
`semanticEquals` to make it more efficient.
You can
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6110#discussion_r30377329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -198,10 +198,12 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6110#discussion_r30321573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -198,10 +198,12 @@ class Analyzer(
g.bi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-102008253
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-102008252
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-102008241
[Test build #32701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32701/consoleFull)
for PR 6110 at commit
[`5c2162e`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101984026
[Test build #32701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32701/consoleFull)
for PR 6110 at commit
[`5c2162e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101983975
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101983959
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101983821
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101540461
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101540434
[Test build #32588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32588/consoleFull)
for PR 6110 at commit
[`5c2162e`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101540466
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101522787
[Test build #32588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32588/consoleFull)
for PR 6110 at commit
[`5c2162e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101522115
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6110#issuecomment-101522063
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101521445
I've updated the code at #6110, but I don't think that's a better solution.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/6110
[SPARK-7269] [SQL] Incorrect analysis for aggregation (new implementation)
This is another implementation other than #5798
You can merge this pull request into a Git repository by running:
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101493450
OK, let's targeting the bug fixing for now, I will update the code soon.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101373181
Using `.find` seems like a pretty reasonable solution to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101216002
Hmm...How about using `Set.find` here instead of `contains`? `find` is
slower than `contains` but we don't care much about performance here, right?
---
If your projec
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101130145
`Set.contains` only support the concrete object parameter, not a function.
Supporting the `semanticEquals` will impact lots of `Expression`s, and
still we cou
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101128074
How about adding `semanticEquals` method to `Expression` like you suggested
before? And we can choose `semanticEquals` as equality function for
`Set.contains` etc. whe
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101109983
Thank you @marmbrus for the explanation. I was thinking if there is a
simple way to make the `Expression` more like a general class, which can be
used with commo
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101089451
If you break equality you will break the `transform` function.
You can't stop people from using expression equality incorrectly, but you
also can't stop them fr
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101081212
Will it be simpler if we refactor the `AttributeReference` that not to
compare the `nullable`, `dataType` or `name`, but `exprId`? If in that case,
then we might
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101067933
The QA phase is not a reason to rush this patch in half finished. This
isn't a regression and there is a trivial workaround (use consistent
capitalization).
I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100792901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100792883
[Test build #32374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32374/consoleFull)
for PR 5798 at commit
[`e00d0bc`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100792898
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100767572
[Test build #32374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32374/consoleFull)
for PR 5798 at commit
[`e00d0bc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100767191
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100767199
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100767039
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100764345
**[Test build #32361 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32361/consoleFull)**
for PR 5798 at commit
[`e00d0bc`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100764355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100764353
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100739964
[Test build #32361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32361/consoleFull)
for PR 5798 at commit
[`e00d0bc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100739850
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100739846
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5798#discussion_r30010033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -159,18 +170,16 @@ object PartialAggregation {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100666817
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100666814
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100666811
[Test build #32348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32348/consoleFull)
for PR 5798 at commit
[`24347ff`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100664819
[Test build #32348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32348/consoleFull)
for PR 5798 at commit
[`24347ff`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100664665
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100664631
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100654519
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100654524
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100654485
[Test build #32341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32341/consoleFull)
for PR 5798 at commit
[`092fdd2`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100653041
[Test build #32341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32341/consoleFull)
for PR 5798 at commit
[`092fdd2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100652969
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100652961
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100650212
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100650194
[Test build #32340 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32340/consoleFull)
for PR 5798 at commit
[`55fef69`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100650213
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100648889
Thank you @cloud-fan & @marmbrus for the suggestion, I added 2 additional
classes `ExpressionSet` and `ExpressionMap`, since now is in the QA stage, I am
not goin
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100647063
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100647075
[Test build #32340 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32340/consoleFull)
for PR 5798 at commit
[`55fef69`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100647054
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5798#discussion_r29994765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -77,4 +77,29 @@ package object expressions {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5798#discussion_r29994732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -77,4 +77,29 @@ package object expressions {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100519451
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100519447
[Test build #32304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32304/consoleFull)
for PR 5798 at commit
[`04cd335`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100519453
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100506153
[Test build #32304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32304/consoleFull)
for PR 5798 at commit
[`04cd335`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100506135
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-100506126
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5798#discussion_r29587194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -137,30 +137,30 @@ object PartialAggregation {
1 - 100 of 165 matches
Mail list logo