Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194070928
Thanks - merging in master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194050736
@rxin Looks like finally everything passed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194041116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194041115
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194040643
**[Test build #52694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52694/consoleFull)**
for PR 11588 at commit
[`8d1f435`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194025026
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194025025
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194024814
**[Test build #52693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52693/consoleFull)**
for PR 11588 at commit
[`8d1f435`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-193989627
**[Test build #52694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52694/consoleFull)**
for PR 11588 at commit
[`8d1f435`](https://gi
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-193987942
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-193987990
**[Test build #52693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52693/consoleFull)**
for PR 11588 at commit
[`8d1f435`](https://gi
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/11588
[SPARK-7286] [SQL] Deprecate !== in favour of =!=
*This PR replaces #9925 which had issues with CI. **Please see the original
PR for any previous discussions.***
## What changes were prop
Github user jodersky closed the pull request at:
https://github.com/apache/spark/pull/9925
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193985859
Closing this PR, will reopen a new one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193961021
I'm not sure - but that's probably a good thing to try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193955460
Jenkins now seems to be stuck on a build :(
@rxin, should I close this PR and create a new one, would this fix the
Jenkins response issues?
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193427261
**[Test build #2613 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2613/consoleFull)**
for PR 9925 at commit
[`214ebb2`](https://git
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193398954
@JoshRosen, sorry to bother you again. Jenkins is ignoring my requests,
could it be that I'm not white-listed anymore?
---
If your project is set up for it, you can re
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192557030
Another use of !== had managed to slip in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192557039
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192552473
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192552475
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192552247
**[Test build #52501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52501/consoleFull)**
for PR 9925 at commit
[`2aa568e`](https://git
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192541637
Thanks! Do you know what was the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192539975
**[Test build #52501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52501/consoleFull)**
for PR 9925 at commit
[`2aa568e`](https://gith
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192539519
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192539515
Not sure; maybe Jenkins was down during the last test requests? Let me try
again.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192533968
@JoshRosen, do you know why Jenkins isn't building this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192383374
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192379806
What's up with jenkins? retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192013276
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191989183
alright
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191984303
Seems that some tests have added !== in the mean-time, I'll update the
references
---
If your project is set up for it, you can reply to this email and have your
repl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191946261
**[Test build #2609 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2609/consoleFull)**
for PR 9925 at commit
[`b60939f`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191927440
**[Test build #2609 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2609/consoleFull)**
for PR 9925 at commit
[`b60939f`](https://git
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191927194
I doesn't matter - the merge script automatically squashes them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191926912
Btw, a general question, do you want me to squash commits as I ammend them
to PRs?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191926014
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191544545
nvm you've already deprecated it.
can you fix the doc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r54827250
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -265,8 +265,26 @@ class Column(protected[sql] val expr: Expression)
extends Logging {
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191544101
@jodersky ok let's do this!
Rather than removing the old one, can you just deprecate it and add the new
one?
---
If your project is set up for it, you can reply
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-190243686
I like @jodersky's solution. As I mentioned on the JIRA, Slick uses the
same operator, so at least there's a precedent, and some people might find it
familiar.
---
If y
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-190072160
I think we should still consider it -- just haven't had time to think about
it more yet.
Can we get somebody from the scala team to also chime in here?
cc
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-189042474
Is this still under consideration? I have no problem closing the issue if
you think it's not a good enough solution.
---
If your project is set up for it, you can repl
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-173123484
We should definitely consider this for Spark 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-172997883
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-172996578
Since the next version of Spark is probably going to be a major release,
would now not be a good time to consider renaming the operator as to achieve
correct behavior?
GitHub user jodersky reopened a pull request:
https://github.com/apache/spark/pull/9925
[SPARK-7286] [SQL] Deprecate !== in favour of =!=
Fixes subtle issues related to operator precedence, as discussed in
SPARK-7286.
I'm not entirely sure this is the right thing to do, per
Github user jodersky closed the pull request at:
https://github.com/apache/spark/pull/9925
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-163708919
I agree that its not pretty, however the only other fix I see is to remove
"$" for columns instead
---
If your project is set up for it, you can reply to this email an
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-163635991
=!= is just really ugly ... let's sleep on this and decide later. There is
no rush since we are not doing it for 1.6.
---
If your project is set up for it, you can reply t
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-162618258
@rxin, just wanted to check if this PR is acceptable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45783799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Exp
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45776287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Express
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-159367936
It has the same issue as !==
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45775846
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Exp
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-159366507
Why not use the more common ```<>``` symbol instead ```=!=```?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45690718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Exp
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45690182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45690058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Express
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45690003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Express
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-159127685
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/9925#discussion_r45688714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -83,7 +83,10 @@ package object dsl {
def >= (other: Exp
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/9925
[SPARK-7286] [SQL] Deprecate !== in favour of =!=
Fixes subtle issues related to operator precedence, as discussed in
SPARK-7286.
I'm not entirely sure this is the right thing to do, perso
65 matches
Mail list logo
