Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-111275848
@rxin, I think that it would be better to make the planning of TakeOrdered
more general such that it can handle internal projections. Either that or we
could also add
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-110979851
Might also be caused by
https://github.com/apache/spark/pull/5831/files#diff-a636a87d8843eeccca90140be91d4fafR156
---
If your project is set up for it, you can reply to
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-110970960
cc @marmbrus actually I think we need a rule like this. @mengxr just
constructed a case:
```
== Parsed Logical Plan ==
Aggregate [brand#1902],
Github user scwf closed the pull request at:
https://github.com/apache/spark/pull/5821
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-101869591
ok to close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-100110996
ping @yhuai is this ok to go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-100115917
[Test build #786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/786/consoleFull)
for PR 5821 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-100148755
[Test build #786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/786/consoleFull)
for PR 5821 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-100321648
I'm not sold on this optimization. Its pretty weird to put an `ORDER BY`
in a subquery, no?
---
If your project is set up for it, you can reply to this email and
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-100404431
yes, but we can not restrict user do not write sql like this.
If you think this is not necessary, i will close this.
---
If your project is set up for it, you can
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-99619138
@yhuai any more comments here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5821#discussion_r29731639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -438,6 +439,17 @@ object CombineFilters extends
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/5821#discussion_r29731959
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -438,6 +439,17 @@ object CombineFilters extends
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-99232779
cc @yhuai can you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98269030
@rxin, i have updated this PR title and description, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98140350
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98140338
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98156997
[Test build #31563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31563/consoleFull)
for PR 5821 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98142739
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98163572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98163557
[Test build #31557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31557/consoleFull)
for PR 5821 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98163571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98142738
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98161050
[Test build #31554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31554/consoleFull)
for PR 5821 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98161062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98161061
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98141013
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98140997
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98141095
[Test build #31557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31557/consoleFull)
for PR 5821 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98156741
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98156717
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98185641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98185639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5821#issuecomment-98185622
[Test build #31563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31563/consoleFull)
for PR 5821 at commit
34 matches
Mail list logo
