[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5833 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102961961 Thanks - merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102956008 @rxin The tests are passed. Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607850 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607849 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607847 [Test build #32902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32902/consoleFull) for PR 5833 at commit [`69bc2b5`](https://git

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607703 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607700 [Test build #32901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32901/consoleFull) for PR 5833 at commit [`69bc2b5`](https://git

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102607704 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591832 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591861 [Test build #32902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32902/consoleFull) for PR 5833 at commit [`69bc2b5`](https://gith

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591827 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591143 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591269 [Test build #32901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32901/consoleFull) for PR 5833 at commit [`69bc2b5`](https://gith

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591147 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591140 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102591120 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102585284 [Test build #32895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32895/consoleFull) for PR 5833 at commit [`69bc2b5`](https://git

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102585287 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102585288 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102584640 [Test build #32895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32895/consoleFull) for PR 5833 at commit [`69bc2b5`](https://gith

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102584583 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102584580 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102584497 @rxin ok. updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-102582289 @viirya can you bring this up to date? I'd like to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98398306 yeah, I could go either way on the test -- I guess the point was mostly to make sure it still worked with DBs, and also to have some example code somebody could try if the

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98339053 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98339055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/316

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98339049 [Test build #31660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31660/consoleFull) for PR 5833 at commit [`928f864`](https://gith

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98326541 [Test build #31660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31660/consoleFull) for PR 5833 at commit [`928f864`](https://githu

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98326489 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98326494 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-02 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98325906 Such a test might be confusing? See if others have some comments for that. I would add some comments to the code. --- If your project is set up for it, you can reply to t

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98207207 its a bummer that this is an Oracle specific thing. Do you think it would be worthwhile to add a test for the behavior in any case, even if in our testing environment it

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-01 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/5833#discussion_r29525237 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala --- @@ -363,7 +363,9 @@ private[sql] class JDBCRDD( case BooleanConv

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98099786 [Test build #31545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31545/consoleFull) for PR 5833 at commit [`5f9da94`](https://gith

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98099790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/315

[GitHub] spark pull request: [SPARK-7299][SQL] Set precision and scale for ...

2015-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5833#issuecomment-98099788 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project