Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-220611530
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-220611532
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-220611311
**[Test build #58982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58982/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-220585349
**[Test build #58982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58982/consoleFull)**
for PR 12066 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r63440571
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -179,7 +230,7 @@ abstract class
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-216540476
@jkbradley Addressed your comments about passing ```numClasses``` to
```generatePredictionMetadata```. This PR is ready for reviewing now. Thanks!
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-216536927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-216536924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-216536793
**[Test build #57639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57639/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-216525374
**[Test build #57639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57639/consoleFull)**
for PR 12066 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61879067
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -137,7 +138,7 @@ abstract class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61878826
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -179,7 +230,7 @@ abstract class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61664866
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -62,6 +92,14 @@ abstract class Classifier[
/** @group
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215936327
@jkbradley Thanks for your comments. I will update this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215830986
Thanks! I replied above & just noted 2 items which remain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61620009
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -179,7 +230,7 @@ abstract class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61620014
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -137,7 +138,7 @@ abstract class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61619308
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -62,6 +92,14 @@ abstract class Classifier[
/** @group
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61617878
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215722396
@jkbradley Addressed most comments except two. Please see my inline replies
and let me know whether it make sense. Thanks.
---
If your project is set up for it,
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61580506
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61579562
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -62,6 +92,14 @@ abstract class Classifier[
/** @group
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215681898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215681896
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215681702
**[Test build #57323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57323/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215663983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215663982
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215663901
**[Test build #57324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57324/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215657544
**[Test build #57324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57324/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215656662
**[Test build #57323 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57323/consoleFull)**
for PR 12066 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215513423
Thanks! Done with pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474754
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -193,6 +195,30 @@ class NaiveBayesSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474700
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -193,6 +195,30 @@ class NaiveBayesSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474596
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -36,8 +37,38 @@ private[spark] trait ClassifierParams
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474427
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474448
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -116,22 +165,7 @@ abstract class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474460
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
---
@@ -94,6 +94,28 @@ private[spark] object SchemaUtils {
/**
*
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -138,22 +138,7 @@ abstract class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474440
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -62,6 +92,14 @@ abstract class Classifier[
/** @group
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474419
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474407
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61474435
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -37,8 +37,38 @@ private[spark] trait ClassifierParams
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215450008
@jkbradley This is ready for another pass. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215448778
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215448783
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215448622
**[Test build #57251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57251/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215434643
**[Test build #57251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57251/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215389944
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215389945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215389914
**[Test build #57244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57244/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215388708
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215388671
**[Test build #57243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57243/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215388707
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215379968
**[Test build #57244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57244/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215379043
**[Test build #57243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57243/consoleFull)**
for PR 12066 at commit
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-215089870
Yes, we have reached a consensus. Thanks.
I will update this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61142716
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -115,7 +116,16 @@ abstract class
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214847453
Responded above. It sounds like we're agreed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214775500
Thanks for your comments, please see my inline replies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r61102661
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -115,7 +116,16 @@ abstract class
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214451920
Thanks, I just responded above. I agree only classification, not
regression, needs to be handled in this PR.
---
If your project is set up for it, you can reply to
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r60953764
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -115,7 +116,16 @@ abstract class
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214136838
@jkbradley Thanks for your comments, please see my inline reply to your
concerns. Because there are no attributes were stored in label column metadata
of
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214127358
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214127359
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214127204
**[Test build #56874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56874/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-214119856
**[Test build #56874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56874/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213503363
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213503359
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213502763
**[Test build #56702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56702/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213470096
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213470102
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213470053
**[Test build #56703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56703/consoleFull)**
for PR 12066 at commit
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213466446
@jkbradley Thanks for your comments, please see my inline reply to your
concerns.
I have add test case. Because there are no attributes were stored in label
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r60752890
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -115,7 +116,16 @@ abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213459391
**[Test build #56703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56703/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213453945
**[Test build #56702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56702/consoleFull)**
for PR 12066 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-213209640
One more thing: Can you please add a unit test? Btw, I know you're working
on a lot of issues, so please say if you'd like help with any.
---
If your project is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12066#discussion_r60485175
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -115,7 +116,16 @@ abstract class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203534421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203534419
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203534255
**[Test build #54531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54531/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203514703
**[Test build #54531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54531/consoleFull)**
for PR 12066 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203512197
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203512201
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203512189
**[Test build #54530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54530/consoleFull)**
for PR 12066 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12066#issuecomment-203511718
**[Test build #54530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54530/consoleFull)**
for PR 12066 at commit
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/12066
[SPARK-7424] [ML] ML ClassificationModel should add metadata to output
column
## What changes were proposed in this pull request?
ML ```ClassificationModel``` should add metadata to output
88 matches
Mail list logo
