[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5974 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100154039 This LGTM. Will leave it a day or two for comments, but the logic seems sound. this improves consistency, behavior vs docs, and avoids an avoidable error --- If your pr

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100153171 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100153175 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100153159 [Test build #32212 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32212/consoleFull) for PR 5974 at commit [`3a3d59c`](https://git

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100127815 [Test build #32212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32212/consoleFull) for PR 5974 at commit [`3a3d59c`](https://gith

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100127741 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100127754 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100114302 [Test build #32201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32201/consoleFull) for PR 5974 at commit [`799976e`](https://git

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100114335 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100114332 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100100777 [Test build #32201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32201/consoleFull) for PR 5974 at commit [`799976e`](https://gith

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100100701 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100100716 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097889 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097881 [Test build #32185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32185/consoleFull) for PR 5974 at commit [`8ddbfae`](https://git

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097887 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097372 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100097363 [Test build #32184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32184/consoleFull) for PR 5974 at commit [`b1b00a3`](https://git

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100096296 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100086491 [Test build #32185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32185/consoleFull) for PR 5974 at commit [`8ddbfae`](https://gith

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100086228 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100086279 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100086226 Removed relativeSD validation in python.Validation is done in scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100084715 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100084843 [Test build #32184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32184/consoleFull) for PR 5974 at commit [`b1b00a3`](https://gith

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-100084676 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99867701 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/321

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99867698 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99867681 [Test build #32107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32107/consoleFull) for PR 5974 at commit [`122d378`](https://gith

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99830420 Ah, I see these checks mirror those in `countApproxDistinctByKey`. OK. But they're slightly different than the essentially-equivalent check in Python:

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99830221 [Test build #32107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32107/consoleFull) for PR 5974 at commit [`122d378`](https://githu

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99830021 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99830003 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99829882 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5974#discussion_r29844326 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1177,8 +1177,9 @@ abstract class RDD[T: ClassTag]( * It must be g

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5974#issuecomment-99752618 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-7438][Spark Core]Fixed validation of re...

2015-05-07 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/5974 [SPARK-7438][Spark Core]Fixed validation of relativeSD in countApproxDistinct You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinodkc/spark f