Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140569774
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140569352
Two failed tests are from core and not related to this PR:
* Unpersisting TorrentBroadcast on executors and driver in distributed mode
*** FAILED *** (11 seconds,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140568143
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140568144
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140568085
[Test build #42501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42501/console)
for PR 7884 at commit
[`e792b6a`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140565693
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140565690
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140565459
[Test build #42502 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42502/console)
for PR 7884 at commit
[`f53436a`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140525616
[Test build #42502 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42502/consoleFull)
for PR 7884 at commit
[`f53436a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140524918
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140524944
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39558685
--- Diff: project/MimaExcludes.scala ---
@@ -73,7 +81,11 @@ object MimaExcludes {
"org.apache.spark.ml.regression.LeastSquaresCostFun.this"),
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39558681
--- Diff: project/MimaExcludes.scala ---
@@ -73,7 +81,11 @@ object MimaExcludes {
"org.apache.spark.ml.regression.LeastSquaresCostFun.this"),
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140524068
[Test build #42501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42501/consoleFull)
for PR 7884 at commit
[`e792b6a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140523818
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140523797
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140519144
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140519058
[Test build #42497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42497/console)
for PR 7884 at commit
[`8d6de99`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140519146
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140491449
[Test build #42497 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42497/consoleFull)
for PR 7884 at commit
[`8d6de99`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140490824
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140490871
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140434004
LGTM but there are some merge conflicts in `MimaExcludes`. Could you fix
them? Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140319560
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140319445
[Test build #42471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42471/console)
for PR 7884 at commit
[`a66833b`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140319562
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140289044
[Test build #42471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42471/consoleFull)
for PR 7884 at commit
[`a66833b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140288415
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140288406
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39476407
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -501,22 +529,27 @@ class LogisticRegressionModel private[ml]
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39474415
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -501,22 +529,27 @@ class LogisticRegressionModel private[ml]
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39474414
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +228,48 @@ class LogisticRegression(override val uid
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140227671
[Test build #42439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42439/console)
for PR 7884 at commit
[`55a28b9`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140227761
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140227762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140194395
[Test build #42439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42439/consoleFull)
for PR 7884 at commit
[`55a28b9`](https://gith
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140193885
JIRA for the behavior of `count` and `numNonZeors` when we make it public.
https://issues.apache.org/jira/browse/SPARK-10597
---
If your project is set up for it, you ca
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140192775
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140192749
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140190915
@jkbradley For `count`, let's do it later since it's a private API.
Currently, `count` will return the actual number of instances, and ignores
instance weights, but `numN
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39436642
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -158,28 +174,28 @@ class MultivariateOnlineSummarizer ext
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140182561
Can you please update the Scala doc to clarify:
* ```count``` ignores instance weights
* Add warning in training summary that it ignores the training weights
cu
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39435586
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +228,48 @@ class LogisticRegression(override val
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39435580
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
@@ -158,28 +174,28 @@ class MultivariateOnlineSummarizer
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140171091
FYI, I made https://issues.apache.org/jira/browse/SPARK-10592 for
deprecating `weights`.
---
If your project is set up for it, you can reply to this email and have your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140163083
I'll make another pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140161878
+1 for "coefficients"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140015704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140015703
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-140015604
[Test build #42411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42411/console)
for PR 7884 at commit
[`9acb9c9`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139978271
[Test build #42411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42411/consoleFull)
for PR 7884 at commit
[`9acb9c9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139977988
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139977971
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139975496
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139975492
[Test build #42408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42408/console)
for PR 7884 at commit
[`7f51d9b`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139975494
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139975103
[Test build #42408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42408/consoleFull)
for PR 7884 at commit
[`7f51d9b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139973808
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139973819
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139968097
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139968069
[Test build #42404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42404/console)
for PR 7884 at commit
[`ad558e2`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139968096
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139966628
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139966629
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139966609
[Test build #42403 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42403/console)
for PR 7884 at commit
[`7bcf592`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139965781
[Test build #42404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42404/consoleFull)
for PR 7884 at commit
[`ad558e2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139963524
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139963539
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139963418
[Test build #42403 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42403/consoleFull)
for PR 7884 at commit
[`7bcf592`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139963190
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-139963181
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r39354759
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38605369
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38604536
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregato
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38603904
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -59,8 +64,7 @@ class LogisticRegressionSuite extends Sp
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38596112
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -781,4 +808,117 @@ class LogisticRegressionSuite extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38595932
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38595939
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-137264169
I will prefer to change the `weights` in linear models to `coefficients` as
well!
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38593540
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -781,4 +808,117 @@ class LogisticRegressionSuite extend
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38590661
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38590409
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-137251694
1. `weight` vs. `sampleWeight`. I don't think `sampleWeight` solves the
problem. I would rather change `weights` in linear models to `coefficients`
instead.
2. Using
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-137251765
@dbtsai I made one pass:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586906
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -833,14 +863,13 @@ private class LogisticCostFun(
v
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586942
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -781,4 +808,117 @@ class LogisticRegressionSuite extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586923
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -59,8 +64,7 @@ class LogisticRegressionSuite extends Sp
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586934
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -216,43 +221,65 @@ class LogisticRegressionSuite extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586917
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -22,10 +22,15 @@ import org.apache.spark.ml.param.Param
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586928
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -216,43 +221,65 @@ class LogisticRegressionSuite extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586864
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -833,14 +863,13 @@ private class LogisticCostFun(
v
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586801
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586798
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586731
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586752
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -499,22 +518,26 @@ class LogisticRegressionModel private[ml]
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586729
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38586744
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,51 @@ class LogisticRegression(override val uid
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-136949391
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-136949392
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
1 - 100 of 278 matches
Mail list logo
