[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103349381 @marmbrus I may misunderstand the nullable flag, but I can have an empty dataset with a non-nullable column. For example : ``` scala val r =

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103381292 I don't really understand, the Array is empty not filled with nulls --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103382692 @rxin any input ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103381022 But you will see null outputs: ```scala a.filter(_1 1).groupBy(_1).agg(avg(_1)).collect res5:Array[org.apache.spark.sql.Row] = Array() ``` ---

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103384521 What does other SQL systems do? i.e. Hive, MySQL. it might make sense for sum ot return 0, but should avg return null if there is no data? --- If your project is

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103402444 From this point of view, I think it's reasonable to say aggregation functions should always be nullable, but depends on different use scenarios. (with / without

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103401627 That's the output from mysql: ``` mysql create table t4(k int, v int); Query OK, 0 rows affected (0.17 sec) mysql select avg(k) from t4;

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103537589 I believe it is the SQL standard that says they should return null. On May 19, 2015 1:51 AM, Cheng Hao notificati...@github.com wrote: From this point of

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103614451 Yup - @ogirardot then we should close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103615700 ok - :-/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-19 Thread ogirardot
Github user ogirardot closed the pull request at: https://github.com/apache/spark/pull/6237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread ogirardot
GitHub user ogirardot opened a pull request: https://github.com/apache/spark/pull/6237 [SPARK-7696][SQL] Aggregate function's result should be nullable only if the input expression is nullable The following functions are now nullable or not according to their child expressions :

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103187164 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103187216 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103188053 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103188036 [Test build #33010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33010/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103187955 [Test build #33010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33010/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103188047 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103189133 added the license to the test file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103189228 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103189160 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103190260 [Test build #33013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33013/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103192299 [Test build #33013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33013/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103192313 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103192308 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103192882 Seems to fail for something completely different : ``` [error]

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103194656 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103194693 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103194816 [Test build #33014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33014/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103195699 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103195695 [Test build #33014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33014/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103195701 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103212193 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103212152 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103212486 [Test build #33019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33019/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103229201 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103229198 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103229162 [Test build #33019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33019/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103294636 I believe that all of these expressions will return null when run on an empty result set, so technically they are always nullable. --- If your project is set up for

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103280526 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103281380 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103281543 [Test build #33036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33036/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103281365 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103304464 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103304456 [Test build #33036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33036/consoleFull) for PR 6237 at commit

[GitHub] spark pull request: [SPARK-7696][SQL] Aggregate function's result ...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6237#issuecomment-103304463 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your