Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110493361
[Test build #34531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34531/consoleFull)
for PR 6423 at commit
[`7e8e0fe`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110492305
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110492262
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110490995
@JoshRosen Makes sense: I'll update the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110490313
@squito Just pushed an update which includes all your suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32057774
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -97,14 +96,12 @@ final class ShuffleBlockFetcherIterator(
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32057745
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K, C](
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32057720
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K, C](
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110484641
Can we update the PR title to better reflect the changes here? Maybe
something succinct that explains how we're pulling the deserialization higher
up the read path st
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110477498
@massie my sailing lingo is pretty rusty, but I'll try to keep it going --
the PR's telltales are smoothly streaming aft now
---
If your project is set up for it, you ca
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110467002
[Test build #34517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34517/console)
for PR 6423 at commit
[`7c8f73e`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110467019
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110466570
I left a few more minor comments, but otherwise this lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32050912
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32050679
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -272,7 +275,7 @@ final class ShuffleBlockFetcherIterator(
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32048775
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -97,14 +96,12 @@ final class ShuffleBlockFetcherIterator(
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32048671
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110461297
ack, sorry @massie the code sample I gave you had bad style ... I always
forget the spaces after `,` ...
---
If your project is set up for it, you can reply to this emai
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110457618
[Test build #34522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34522/console)
for PR 6423 at commit
[`01e8721`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110457622
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110457264
[Test build #34522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34522/consoleFull)
for PR 6423 at commit
[`01e8721`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110456826
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110456897
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32046806
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32042413
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32040367
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110439557
[Test build #34517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34517/consoleFull)
for PR 6423 at commit
[`7c8f73e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110438915
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110438887
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110438760
@squito I fixed the Scala style issue and updated the `HashShuffleReader`
to close each Block `InputStream` sooner -- immediately after all records are
read.
I h
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32038003
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32017015
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110364223
thanks @massie. That makes more sense now -- in fact I should have seen
the jira had a link to https://issues.apache.org/jira/browse/SPARK-7263 , my
mistake.
---
If
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32013943
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110184535
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110184510
[Test build #34471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34471/console)
for PR 6423 at commit
[`208b7a5`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110167932
[Test build #34471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34471/consoleFull)
for PR 6423 at commit
[`208b7a5`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110167831
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110167852
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110166232
@squito I appreciate the feedback. No need to apologize for asking for an
explanation of why this PR is important.
This work is only indirectly related to Parquet
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31966729
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -79,11 +78,11 @@ final class ShuffleBlockFetcherIterator(
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31966686
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31963930
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31963587
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -79,11 +78,11 @@ final class ShuffleBlockFetcherIterator(
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110151707
I really appreciate keeping the PR small in scope to make it easier to
review -- but I am also a little torn that I have a hard time seeing concretely
the advantage of th
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31962636
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -298,11 +294,9 @@ final class ShuffleBlockFetcherIterator(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108137660
[Test build #34026 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34026/consoleFull)
for PR 6423 at commit
[`b70c945`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108137667
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108114244
[Test build #34026 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34026/consoleFull)
for PR 6423 at commit
[`b70c945`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108113358
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108113372
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31542306
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-108002390
Thanks for the tip. I'll make sure to leave the commits separate moving
forward.
I looked into the use of `Try` between the `BlockStoreShuffleFetcher` and
`Shuff
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107998999
By the way, you don't need to squash your commits together, since our merge
script will now take care of it when we commit things. Leaving them separate
makes it easi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107821941
[Test build #33954 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33954/consoleFull)
for PR 6423 at commit
[`19135f2`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107821971
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107798074
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107798174
[Test build #33954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33954/consoleFull)
for PR 6423 at commit
[`19135f2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107798025
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107796875
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107764072
I understand what it causing the tests to fail. I've have an update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107733961
[Test build #33919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33919/consoleFull)
for PR 6423 at commit
[`e2078e8`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107733973
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107712346
I fixed the broken unit test, scala style issues, addressed the concerns
that were raised, squashed the commits and rebased on the top of master.
Keep the comment
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107711802
[Test build #33919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33919/consoleFull)
for PR 6423 at commit
[`e2078e8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107710109
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-107710144
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31448383
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -17,21 +17,20 @@
package org.apache.spark.stor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31374250
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -17,21 +17,20 @@
package org.apache.spa
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106963545
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106963534
[Test build #33778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33778/consoleFull)
for PR 6423 at commit
[`418b103`](https://git
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371578
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -17,23 +17,22 @@
package org.apache.spark.shuffle
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371560
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -53,12 +52,13 @@ private[hash] object BlockStoreShuffleFetch
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371544
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371478
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -17,21 +17,20 @@
package org.apache.spark.stor
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371407
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371387
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106952818
I rebased this work on ToT and added a new commit that uses an InputStream
decorator to ensure that the buffer is released on `close()`. The code is a lot
more cleaner wi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106952736
[Test build #33778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33778/consoleFull)
for PR 6423 at commit
[`418b103`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106952623
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106952638
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371101
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -17,23 +17,22 @@
package org.apache.spark.shuf
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371083
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -53,12 +52,13 @@ private[hash] object BlockStoreShuffleFe
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371019
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,11 +33,34 @@ private[spark] class HashShuffleReader[K, C](
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370901
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -17,21 +17,20 @@
package org.apache.spark.s
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370848
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -17,22 +17,23 @@
package org.apache.spark.storag
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370774
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370568
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370480
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106951335
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106951332
[Test build #33777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33777/consoleFull)
for PR 6423 at commit
[`b12f912`](https://git
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370405
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370342
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106950972
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106951064
[Test build #33777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33777/consoleFull)
for PR 6423 at commit
[`b12f912`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-106950963
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31364286
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -298,11 +294,9 @@ final class ShuffleBlockFetcherIterator(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31363983
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -17,23 +17,22 @@
package org.apache.spark.shuf
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31363070
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -298,11 +294,9 @@ final class ShuffleBlockFetcherIterator(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31362756
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -298,11 +294,9 @@ final class ShuffleBlockFetcherIterator(
1 - 100 of 128 matches
Mail list logo
