Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114746508
I will do a final pass on this and then merge tomorrow!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114747817
Thanks, @kayousterhout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-11503
@kayousterhout Is this still on track for merging today? Let me know if you
see anything else that needs to be done.
---
If your project is set up for it, you can reply
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-115080253
Rebasing or squashing shouldn't be necessary
Sent from my phone
On Jun 24, 2015, at 7:13 PM, Matt Massie notificati...@github.com wrote:
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-115071736
@kayousterhout I'm happy to squash the commits and rebase them on `master`,
if that helps.
---
If your project is set up for it, you can reply to this email and have
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-115107689
Thanks for all of your work on this @massie! This is now merged into
master.
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114563503
@kayousterhout @rxin All the tests passed. Let me know if you'd like any
more changes made and I'll get to them immediately.
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114706266
[Test build #35609 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35609/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114706289
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114675252
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114675262
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114675373
[Test build #35608 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35608/consoleFull)
for PR 6423 at commit
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114676352
derp this is my fault...just forgot to mark RecordingManagedBuffer as
private[spark]!
---
If your project is set up for it, you can reply to this email and have
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114676939
No worries. I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114678116
[Test build #35609 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35609/consoleFull)
for PR 6423 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114675621
[Test build #35608 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35608/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114675623
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114677437
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114677453
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114295773
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114295684
@kayousterhout @rxin I just pushed an update which adds a test specifically
to validate that the `HashShuffleReader.read()` method is properly reading
values, saving
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114295736
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114296040
[Test build #35492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35492/consoleFull)
for PR 6423 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114318940
[Test build #35492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35492/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-114318967
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113553309
I make the updates first thing next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32746147
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113376197
I talked to @kayousterhout a bit more offline. I think it is actually
pretty important to have the same level of test coverage, since this code is
very important tricky
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113332476
[Test build #35185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35185/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113332502
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32759619
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32774012
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113244059
@massie thanks for updating the tests. It's still a little concerning to
me that we don't explicitly check that the iterator returned from
HashShuffleReader
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32774776
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311225
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311202
[Test build #35176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35176/console)
for PR 6423 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311323
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311736
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311776
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113299547
[Test build #35176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35176/consoleFull)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113299366
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113299389
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113300714
@kayousterhout, Thanks for reviewing this PR. I agree that we should be
more defensive moving forward. I think the right next step (no pun intended) is
to [Update
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113311953
[Test build #35185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35185/consoleFull)
for PR 6423 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113048811
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113049213
[Test build #35095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35095/consoleFull)
for PR 6423 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32703910
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +314,40 @@ final class ShuffleBlockFetcherIterator(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32703906
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +314,40 @@ final class ShuffleBlockFetcherIterator(
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113060351
overall lgtm. just couple nits.
the question about potential memory leak -- I hope I just overlooked
something.
---
If your project is set up for it, you can
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32704110
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -290,22 +287,15 @@ final class ShuffleBlockFetcherIterator(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113048892
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113048878
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113069263
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-113069241
[Test build #35095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35095/console)
for PR 6423 at commit
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111880817
@rxin I'm looking forward to hearing your thoughts about this change. Let
me know if you have any questions or suggestions.
---
If your project is set up for it, you
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111378626
Sorry has to be this weekend. Still busy with some other stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111597219
[Test build #34787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34787/consoleFull)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111597155
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111593279
[Test build #34786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34786/consoleFull)
for PR 6423 at commit
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111593360
@kayousterhout I just pushed an update which checks that
`BufferReleasingInputStream` is not just releasing memory but also closing the
underlying delegate
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111617246
[Test build #34786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34786/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111617277
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111597138
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111623567
[Test build #34787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34787/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111623602
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111593111
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111593134
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111515701
@kayousterhout I'll work on improving the unit tests today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32278636
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,23 +34,55 @@ private[spark] class HashShuffleReader[K, C](
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111307212
My only remaining concern is with the unit test: we used to check that the
buffer got released when the iterator was exhausted. Now, we test that the
buffer is
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32284938
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,23 +34,55 @@ private[spark] class HashShuffleReader[K, C](
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32242149
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,23 +34,55 @@ private[spark] class HashShuffleReader[K, C](
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111207353
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111207381
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111208258
[Test build #34697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34697/consoleFull)
for PR 6423 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111237381
[Test build #34697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34697/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111237392
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111240310
WooHoo! All the tests passed.
Thanks for all the help on this @kayousterhout, @squito, @JoshRosen and
@sryza. Let me know if you see anything you'd like
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32256571
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,23 +34,55 @@ private[spark] class HashShuffleReader[K, C](
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111246687
lgtm (the discussion I just started about types of iterators shouldn't
effect whether or not this can be merged)
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110889442
[Test build #34626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34626/console)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110889462
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110854882
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110855046
[Test build #34626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34626/consoleFull)
for PR 6423 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110854846
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173545
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -17,21 +17,22 @@
package
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173819
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -104,10 +113,13 @@ class
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173214
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K,
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110937046
Just a few last cosmetic comments...then I'm happy to merge unless
@JoshRosen has any last objections.
---
If your project is set up for it, you can reply to
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32174449
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K, C](
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173458
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -17,23 +17,21 @@
package
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110936800
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173860
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -57,7 +58,16 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110936815
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32172460
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala
---
@@ -17,23 +17,21 @@
package
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32173361
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -33,17 +34,52 @@ private[spark] class HashShuffleReader[K,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110937218
[Test build #34640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34640/consoleFull)
for PR 6423 at commit
Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32177982
--- Diff:
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala
---
@@ -57,7 +58,16 @@ class ShuffleBlockFetcherIteratorSuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-110948271
[Test build #34643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34643/consoleFull)
for PR 6423 at commit
1 - 100 of 148 matches
Mail list logo
