[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the "App ID"...

2015-12-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-168112847 I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks! --- If your project

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the "App ID"...

2015-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the "App ID"...

2015-11-23 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-158969374 ...I'm looking at this and my PR; I think they are differently interdependent. 1. This patch adds a new method to `ApplicationHistoryProvider` for the

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-121072226 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-23 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-114570582 sorry for the delay, I'm just looking at this again. @steveloughran I want to make sure I understand what you are proposing -- that fix would be totally independent of

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-23 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-114656223 -yes, independent. SPARK-1537: implements the HistoryProvider in YARN, gets it from ATS, etc, etc. The JIRA we are looking at here, where my patch is

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-18 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-113358887 @squito, Can you pay attention on this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-16 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-112366005 1. I can do the test as part of SPARK-1537; indeed, I already have it replicated, I've just turned that test off. That code already has everything needed

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110469587 OK no problem @XuTingjun , happy to help, though I think unfortunately I am unlikely to get to this until after spark summit. Sorry for the delay, feel free to bug me

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-09 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110477739 Jenkins, this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-08 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110155875 jenkins, ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-08 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110155715 Hi @XuTingjun the updated description makes sense. Also I took a *really* quick look at the patch and it seems reasonable. however I'm going to defer reviewing this

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-08 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110192207 Hi @squito, I think I need your help, I am not clearly know how to write this test. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-08 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-110191346 @squito, I think you can help me, I am not clearly know how to write this test, thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-03 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-108708777 I think the reason is not just because of the appCache. After my debug the code, I found there are two mainly reasons: 1. First time send */history/appid* request,

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-02 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107833438 I wonder if it is a good idea that we have a custom HandlerCollection. The cause of the problem is the cache mechanism in `HistoryServer`. The current HistoryServer

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-02 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107912763 @tsudukim Sorry, I don't agree with you, spark.history.retainedApplications can't to be 0 I think --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-02 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107985041 It makes sense that the issue might be from caching applications. I think @tsudukim wasn't saying that spark.history.retainedApplications = 0 is a permanent solution,

[GitHub] spark pull request: [SPARK-7889] [UI] make sure click the App ID...

2015-06-01 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107774238 @tsudukim hey, I think this bug is introduced by #3467, can you have a look? --- If your project is set up for it, you can reply to this email and have your reply