[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107831127 [Test build #33963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33963/consoleFull) for PR 6574 at commit

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107839759 [Test build #33960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33960/consoleFull) for PR 6574 at commit

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107839781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107830811 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107830826 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107826524 We should handle those as well ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6574#discussion_r31494627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -485,13 +485,15 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-02 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107825414 Just realized decimal literal's type is not always `DecimalType.Unlimited`. User can do something like `Literal.create(Decimal(1), DecimalType(8, 0))`. Should we

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107812283 cc @marmbrus @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/6574 [SPARK-7952][SQL] compare Literals instead of its value in BooleanEqualization This PR fixes a bug introduced in https://github.com/apache/spark/pull/6505. Decimal literal's values is not

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107813186 [Test build #33960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33960/consoleFull) for PR 6574 at commit

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107813089 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107813102 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107820275 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-7952][SQL] compare Literals instead of ...

2015-06-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6574#issuecomment-107817793 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and