Github user watermen closed the pull request at:
https://github.com/apache/spark/pull/6518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113585286
@watermen I think the decision then is to not merge this patch. Whether or
not the intended change is correct (and it is likely not, according to
@srowen), this break
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113450820
The number of partitions is generally equal to the number of files. I don't
think it can be less; it can be more. Really, the minPartitions setting rarely
does anything;
Github user watermen commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113425007
@srowen `wholeTextFiles` used to combine small files, and the actual number
of partition(task) is less than or equal to partitionsNum user pass.
---
If your project is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113416067
I don't understand this. The value `minPartitions` is passed to
`InputFormat.setMinPartitions`. Why do you think it's a max?
---
If your project is set up for it, you ca
Github user watermen commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113385401
@andrewor14 Can we add new method `newWholeTextFiles(path: String,
maxPartitions: Int)`? and
```
wholeTextFiles(path: String, minPartitions: Int = defaultMinPar
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113354424
Yes, but that by itself maybe a reason why we can't merge this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user watermen commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113348183
@andrewor14 you mean the code like `wholeTextFiles("path",
minPartitions=1)`? Others will not have the problem of backward compatible.
---
If your project is set up fo
Github user watermen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6518#discussion_r32797175
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -825,11 +825,11 @@ class SparkContext(config: SparkConf) extends Logging
with Execut
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113312583
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113312560
[Test build #35172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35172/console)
for PR 6518 at commit
[`cd64289`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113292891
[Test build #35172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35172/consoleFull)
for PR 6518 at commit
[`cd64289`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113292333
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113292297
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113292250
Also, it seems that here we're changing parameter names of public APIs.
This is not backward compatible right?
---
If your project is set up for it, you can reply to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6518#issuecomment-113291733
ok to test. @srowen does this seem valid to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6518#discussion_r32779200
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -825,11 +825,11 @@ class SparkContext(config: SparkConf) extends Logging
with Exec
17 matches
Mail list logo
