[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108620445 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6546#discussion_r31672318 --- Diff: core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala --- @@ -55,6 +55,14 @@ class ExternalShuffleServiceSuite extends

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108622380 [Test build #34116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34116/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108651869 **[Test build #34116 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34116/consoleFull)** for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108651887 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108622215 @zsxwing IIUC this only adds some wait logic for the two test suites, but the intent is that we don't change the logic in `BroadcastSuite` right? --- If your

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108622240 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108622258 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6546#discussion_r31672295 --- Diff: core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala --- @@ -55,6 +55,14 @@ class ExternalShuffleServiceSuite extends

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108621327 @zsxwing why does this reduce the flakiness? What is the source of the flakiness? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108628275 master 1.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-03 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-108699116 @zsxwing IIUC this only adds some wait logic for the two test suites, but the intent is that we don't change the logic in BroadcastSuite right? Right.

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107422149 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107422137 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107422417 [Test build #33888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33888/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107419985 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107419976 **[Test build #33885 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33885/consoleFull)** for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107421913 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107382508 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107382587 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107379861 @zsxwing are these things you identify actually causing test failures for you or in Jenkins or is this theoretical? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107381194 @srowen These two failures happened in my PR #6457. I fixed them in #6457 to pass Jenkins. But I think they are not a part of #6457 and it's better to fix them in a

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107382981 [Test build #33885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33885/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107510785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107510724 [Test build #33888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33888/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107657279 if this is just for testing, how about we put it into a SparkListener in the tests instead, and avoid changing `JobProgressListener`? You could put it into a common

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107748117 if this is just for testing, how about we put it into a SparkListener in the tests instead, and avoid changing JobProgressListener? You could put it into a common

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-06-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107753794 The problem of a new SparkListener is adding an Executor may happen before adding the new SparkListener to SparkContext. So the new SparkListener may miss some

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107293380 [Test build #33872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33872/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/6546 [SPARK-7989][Core][Tests] Fix flaky tests in ExternalShuffleServiceSuite and SparkListenerWithClusterSuite The flaky tests in ExternalShuffleServiceSuite and SparkListenerWithClusterSuite will

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107293189 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107293150 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107305325 [Test build #33872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33872/consoleFull) for PR 6546 at commit

[GitHub] spark pull request: [SPARK-7989][Core][Tests] Fix flaky tests in E...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6546#issuecomment-107305335 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your