Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35614790
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -184,4 +184,26 @@ class DateFunctionsSuite extends QueryTest {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35614426
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -184,4 +184,26 @@ class DateFunctionsSuite extends QueryTest {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6986
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125432526
Thanks - I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125426994
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125426722
[Test build #38627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38627/console)
for PR 6986 at commit
[`dc69630`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125420502
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125420457
[Test build #38645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38645/console)
for PR 6986 at commit
[`ef7e3da`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125417809
[Test build #38645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38645/consoleFull)
for PR 6986 at commit
[`ef7e3da`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125417698
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125417685
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125416151
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125416142
[Test build #38634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38634/console)
for PR 6986 at commit
[`02b3426`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125411796
[Test build #38634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38634/consoleFull)
for PR 6986 at commit
[`02b3426`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125411191
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125411251
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125411264
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125410122
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125407891
Can you address these two issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35608605
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2392,6 +2399,16 @@ object functions {
def minute(columnName: String): Column
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35608581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,50 @@ object DateTimeUtils {
dayInYea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35608548
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2392,6 +2399,16 @@ object functions {
def minute(columnName: String): Column
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125406041
[Test build #38627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38627/consoleFull)
for PR 6986 at commit
[`dc69630`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125405354
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125405335
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35607203
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2392,6 +2399,13 @@ object functions {
def minute(columnName: String):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125332946
@adrian-wang I think this one is pretty close - we need to add more user
facing documentation and internal comments, as well as unit tests.
Thanks.
---
If your pr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35582133
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,48 @@ object DateTimeUtils {
dayInYea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35581950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,48 @@ object DateTimeUtils {
dayInYea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35582006
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2392,6 +2399,13 @@ object functions {
def minute(columnName: String): Column
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35581693
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2392,6 +2399,13 @@ object functions {
def minute(columnName: String): Column
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35581446
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,48 @@ object DateTimeUtils {
dayInYea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35581417
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -246,4 +247,19 @@ class DateExpressionsSuite e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125174034
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125173929
[Test build #38533 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38533/console)
for PR 6986 at commit
[`8846086`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125152991
[Test build #38533 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38533/consoleFull)
for PR 6986 at commit
[`8846086`](https://gith
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35520838
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatCla
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125151627
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-125151650
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35501909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35501773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490337
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,35 @@ object DateTimeUtils {
dayInYea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35490281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,62 @@ case class DateFormatClass(left
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124653500
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124653038
[Test build #38382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38382/console)
for PR 6986 at commit
[`d09bcce`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124594473
[Test build #38382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38382/consoleFull)
for PR 6986 at commit
[`d09bcce`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124592129
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124592053
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124063830
@rxin @chenghao-intel @zhichao-li
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124046707
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124046293
[Test build #38203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38203/console)
for PR 6986 at commit
[`2d0629b`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124022506
[Test build #38203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38203/consoleFull)
for PR 6986 at commit
[`2d0629b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124022285
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-124022300
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
59 matches
Mail list logo
