[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122145516 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122145563 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122145749 [Test build #37563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37563/consoleFull) for PR 6872 at commit [`e2bace3`](https://gith

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122156962 [Test build #37563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37563/console) for PR 6872 at commit [`e2bace3`](https://github.

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122157016 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34862499 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +96,11 @@ class MathFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34862483 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -67,6 +67,24 @@ object functions { def column(colName: String): Column = Colu

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122177665 @zhichao-li this is really close. Let's add some test cases and then merge it. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122200219 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122200238 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122200386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34866886 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -139,6 +140,190 @@ case class Cos(child: Expression) extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34866951 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34867509 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite e

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34867780 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34867870 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite e

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34868017 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34868337 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite e

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r34868495 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -95,6 +94,19 @@ class MathFunctionsSuite extends

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122211251 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122211288 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122211989 [Test build #37607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37607/consoleFull) for PR 6872 at commit [`6ef3b37`](https://gith

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122212284 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122235511 [Test build #37607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37607/console) for PR 6872 at commit [`6ef3b37`](https://github.

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122235634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-122334117 Thanks. I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-06-25 Thread zhichao-li
Github user zhichao-li commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-115457607 cc @chenghao-intel @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/6872#issuecomment-115457780 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 이 다음과 같은 이유로 전송

[GitHub] spark pull request: [SPARK-8209[SQL]Add function conv

2015-07-02 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6872#discussion_r33774116 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -67,6 +67,24 @@ object functions { def column(colName: String): Col