[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114749737 [Test build #35653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35653/consoleFull) for PR 6976 at commit

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33124584 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -275,9 +279,6 @@ case class Atan2(left: Expression,

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114774291 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114774223 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114789157 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114789113 [Test build #35653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35653/console) for PR 6976 at commit

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33124278 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -289,6 +290,97 @@ case class Pow(left: Expression,

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33124973 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -275,9 +279,6 @@ case class Atan2(left: Expression,

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114774621 [Test build #35664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35664/consoleFull) for PR 6976 at commit

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33125097 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -20,7 +20,7 @@ package

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread zhichao-li
GitHub user zhichao-li opened a pull request: https://github.com/apache/spark/pull/6976 [SPARK-8214][SQL][WIP]Add function hex cc @chenghao-intel @adrian-wang You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhichao-li/spark hex

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114749419 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114749408 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33124454 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala --- @@ -20,7 +20,7 @@ package

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33124487 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1047,6 +1047,22 @@ object functions { def floor(columnName: String):

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114854714 LGTM, except a minor issue. Can you also remove the WIP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6976#discussion_r33142999 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -289,6 +290,96 @@ case class Pow(left: Expression,

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114812708 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8214][SQL][WIP]Add function hex

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6976#issuecomment-114812624 [Test build #35664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35664/console) for PR 6976 at commit