Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127865432
Merged into master and 1.5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127861924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127861639
[Test build #39816 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39816/console)
for PR 7949 at commit
[`d3c08bc`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127833739
[Test build #39816 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39816/consoleFull)
for PR 7949 at commit
[`d3c08bc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127832570
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127832546
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7949#discussion_r36266455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -115,3 +116,73 @@ case class SortArray(base:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7949#discussion_r36266408
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -115,3 +116,73 @@ case class SortArray(ba
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127810249
[Test build #1341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1341/console)
for PR 7949 at commit
[`bc3d1fe`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127791250
[Test build #1341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1341/consoleFull)
for PR 7949 at commit
[`bc3d1fe`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127790149
[Test build #39778 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39778/console)
for PR 7949 at commit
[`bc3d1fe`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127790153
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127790068
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127790138
[Test build #39778 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39778/consoleFull)
for PR 7949 at commit
[`bc3d1fe`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7949#issuecomment-127790020
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/7949
[SPARK-8231][SQL] Add array_contains
This PR is based on #7580 , thanks to @EntilZha
PR for work on https://issues.apache.org/jira/browse/SPARK-8231
Currently, I have an initial imp
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127132905
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127132897
[Test build #39516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39516/console)
for PR 7580 at commit
[`e352cf9`](https://github.
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127132676
Same compile error unfortunately. Probably at this point best to pass off.
The only unpushed change is:
```scala
arr.asInstanceOf[ArrayData].toArray(right.dataTy
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127132250
I will give that workaround a shot. Don't want to push the code above
without running the test suite. If it passes I will push it.
As for being away from comput
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131799
@EntilZha I can take over this, if you are away from computer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131704
@EntilZha The compile error is anonying, could be workaround by `build/sbt
clean`.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131369
@davies, I just pushed updates except for the fix for `ArrayData`. I
rebased to master and am getting unrelated compile errors, so will have to wait
for that to be fixe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131364
[Test build #39516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39516/consoleFull)
for PR 7580 at commit
[`e352cf9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131246
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-127131240
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36056912
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user EntilZha commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36056386
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Exp
Github user EntilZha commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36056381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Exp
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039703
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039658
--- Diff: python/pyspark/sql/functions.py ---
@@ -850,6 +851,22 @@ def size(col):
return Column(sc._jvm.functions.size(_to_java_column(col)))
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-126777044
Thanks for update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-126775607
@EntilZha don't worry we will let this one in, since it is submitted early,
very isolated, and strictly additive.
Mostly bottlenecked by reviewer time right now.
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-126749986
Another ping for a review since feature freeze is today/Monday @rxin and
@chenghao-intel.
---
If your project is set up for it, you can reply to this email and have y
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123588858
BTW, @EntilZha, can you place a `[WIP]` in the title if you still working
on it?
---
If your project is set up for it, you can reply to this email and have your
Github user EntilZha commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35187090
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -298,4 +298,32 @@ class DataFrameFunctionsSuite extends QueryTest
Github user EntilZha commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35187063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,57 @@ case class Size(child: Exp
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123588213
> 2. I have defined checkInputDataTypes. Based on the requirement to check
that argument one is of type Array[T] and that the value to check is of type T,
it does
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123581993
@EntilZha can you also add the python DF API support?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35185849
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2081,6 +2081,22 @@ object functions {
*/
def size(column:
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35185806
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -298,4 +298,32 @@ class DataFrameFunctionsSuite extends Que
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r35185755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,57 @@ case class Size(chil
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123531926
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123531919
[Test build #38011 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38011/console)
for PR 7580 at commit
[`fe88d63`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123531191
[Test build #38011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38011/consoleFull)
for PR 7580 at commit
[`fe88d63`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123530273
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123530306
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123526249
[Test build #38008 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38008/console)
for PR 7580 at commit
[`6e01e53`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123526251
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123526078
[Test build #38008 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38008/consoleFull)
for PR 7580 at commit
[`6e01e53`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123525996
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123526005
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521522
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521518
[Test build #38000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38000/console)
for PR 7580 at commit
[`c8b5254`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521342
[Test build #38000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38000/consoleFull)
for PR 7580 at commit
[`c8b5254`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521174
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521183
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123521163
Consolidating all my questions here, then deleting prior comments:
1. What is incorrect about my codegen which is returning an error?
Secondary to that, does it make
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123513491
For type checking, should this be done in `eval` or in `inputTypes`? If the
second, is there a way to constrain the type of the right by the element type
of the left?
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123511627
Are the primitives declared somewhere else, or do I need to declare their
type?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123511552
Stack trace for failed codegen:
```scala
[info] - Array contains *** FAILED *** (25 milliseconds)
[info] Code generation of array_contains(List(1, 2, 3
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123509405
[Test build #37996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37996/console)
for PR 7580 at commit
[`a4ef4e2`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123509406
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123508967
[Test build #37996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37996/consoleFull)
for PR 7580 at commit
[`a4ef4e2`](https://gith
GitHub user EntilZha opened a pull request:
https://github.com/apache/spark/pull/7580
[SPARK-8231][SQL] Add array_contains
PR for work on https://issues.apache.org/jira/browse/SPARK-8231
Currently, I have an initial implementation for contains. Based on
discussion on JIRA,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123507747
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7580#issuecomment-123507789
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
74 matches
Mail list logo
