[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-07-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/6824#discussion_r33968235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -621,7 +621,7 @@ class Column(protected[sql] val expr: Expression) extends Logging

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-07-06 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6824#discussion_r33970553 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -621,7 +621,7 @@ class Column(protected[sql] val expr: Expression) extends Logging {

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113388126 I also created an issue for the python version. https://issues.apache.org/jira/browse/SPARK-8477 --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113387694 Yes, will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113387113 Can you add the Python version too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6824 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113386983 Thank you for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113386939 Thanks. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113385356 [Test build #35220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35220/console) for PR 6824 at commit [`e76d02f`](https://github.

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113385404 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113359947 [Test build #35220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35220/consoleFull) for PR 6824 at commit [`e76d02f`](https://gith

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113359883 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113359872 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/6824#discussion_r32796061 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -296,6 +296,28 @@ class ColumnExpressionSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6824#discussion_r32795774 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -296,6 +296,28 @@ class ColumnExpressionSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113329141 @rxin Could you please check it? I have fixed the test cases. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113213822 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113213781 [Test build #35135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35135/console) for PR 6824 at commit [`6f744ac`](https://github.

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113183907 [Test build #35135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35135/consoleFull) for PR 6824 at commit [`6f744ac`](https://gith

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113182938 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113182987 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113181215 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113071388 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113071330 [Test build #35104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35104/console) for PR 6824 at commit [`6f744ac`](https://github.

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113060750 [Test build #35104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35104/consoleFull) for PR 6824 at commit [`6f744ac`](https://gith

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113060303 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113060334 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-17 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113054779 @rxin Thank you for your feedback. I'll fix the test cases soon. As you said, it is hard to implement `%in%` operator in SparkR. And we don't have any operator

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6824#discussion_r32702554 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -296,6 +296,15 @@ class ColumnExpressionSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-113053359 I think it is ok to add the R stuff later. It is pretty hard for everyone to learn R and add all the expressions. Also considering there is a selectExpr workaround ... -

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-16 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-112470314 We don't have a developer guide yet for SparkR, but it design is pretty similar to the PySpark. For example you can see this PR which added math operations to SparkR h

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-16 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-112316855 @shivaram Got it. Is there any documentation how to develop SparkR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-112119776 As mentioned in the JIRA, we should also do this for the R API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-112023917 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-112023895 [Test build #34924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34924/console) for PR 6824 at commit [`00077d3`](https://github.

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-111990552 [Test build #34924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34924/consoleFull) for PR 6824 at commit [`00077d3`](https://gith

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-111989385 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6824#issuecomment-111974406 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8348][SQL] Add in operator to DataFrame...

2015-06-15 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/6824 [SPARK-8348][SQL] Add in operator to DataFrame Column I have added it for only Scala. TODO: we should also support `in` operator in Python. You can merge this pull request into a Git reposi