[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6896 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113585900 LGTM. Merging. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113447318 A lot of similar stuff was done in 1.3 in SPARK-3288: https://github.com/apache/spark/commit/3453d578ad9933be6881488c8ca3611e5b686af9 Seems consistent, yeah. @rxi

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-19 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113425855 @srowen, Thank you for your comment. Yes, it's a developer API for getters, but I think setters should not open for developers like other setters of this class because

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-19 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113415292 It's a developer API, but is it worth hiding at this point? does it cause problems? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113395829 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113395809 [Test build #35222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35222/console) for PR 6896 at commit [`89251d8`](https://github.

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113370358 [Test build #35222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35222/consoleFull) for PR 6896 at commit [`89251d8`](https://gith

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113370169 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6896#issuecomment-113370152 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8476] [CORE] Setters inc/decDiskBytesSp...

2015-06-18 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/6896 [SPARK-8476] [CORE] Setters inc/decDiskBytesSpilled in TaskMetrics should also be private. This is a follow-up of [SPARK-3288](https://issues.apache.org/jira/browse/SPARK-3288). You can merge this