Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113838652
@shivaram Thank you for reviewing! I agree with you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113837953
LGTM. Thanks @yu-iskw -- BTW we should fix the existing style issues before
turning it on for Jenkins but lets discuss more on the JIRA for this.
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113835821
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113835768
[Test build #35371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35371/console)
for PR 6922 at commit
[`c1ffe6b`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819517
[Test build #35371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35371/consoleFull)
for PR 6922 at commit
[`c1ffe6b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819338
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819331
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819164
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819087
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113819080
[Test build #35370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35370/console)
for PR 6922 at commit
[`c1ffe6b`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113817413
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113817405
[Test build #35367 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35367/console)
for PR 6922 at commit
[`5520806`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113813186
[Test build #35370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35370/consoleFull)
for PR 6922 at commit
[`c1ffe6b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113811671
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113811610
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113811031
@shivaram Thank you for your feedback.
- save the result to a log file
- Add the rule to the `.lintr` file
---
If your project is set up for it, you can rep
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/6922#discussion_r32886959
--- Diff: R/pkg/.lintr ---
@@ -0,0 +1,2 @@
+linters: with_defaults(line_length_linter(100))
--- End diff --
Could you also add `camel_case_li
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/6922#discussion_r32886955
--- Diff: dev/lint-r ---
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113800283
[Test build #35367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35367/consoleFull)
for PR 6922 at commit
[`5520806`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113799726
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113799720
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113799298
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113799295
[Test build #35366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35366/console)
for PR 6922 at commit
[`8f94680`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113799275
[Test build #35366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35366/consoleFull)
for PR 6922 at commit
[`8f94680`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113798471
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113798530
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/6922#issuecomment-113798277
@shivaram Could you review it when you have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/6922
[SPARK-8495][SparkR] Add a `.lintr` file to validate the SparkR files and
the `lint-r` script
Thank Shivaram Venkataraman for your support. This is a prototype script to
validate the R files.
You
29 matches
Mail list logo
