Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115922280
No problem!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115921782
LGTM. That test case looks great. Thanks @cafreeman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115918807
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115918784
[Test build #35884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35884/consoleFull)
for PR 7001 at commit
[`8f81194`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115889749
[Test build #35884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35884/consoleFull)
for PR 7001 at commit
[`8f81194`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-11537
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115888689
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115887210
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115874656
Hmm - weirdly the Scala spark-submit test failed. Lets give this another go
and see if it was just a flaky test.
Jenkins, retest this please
---
If your proje
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115874232
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115874183
[Test build #35876 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35876/consoleFull)
for PR 7001 at commit
[`8f81194`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115840122
[Test build #35876 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35876/consoleFull)
for PR 7001 at commit
[`8f81194`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115837457
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115837394
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115835716
@shivaram Took your advice and changed things so that the test runs another
script using R's `system2`. The tests work now :)
---
If your project is set up for it, yo
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115764745
So I took a look at this and I managed to figure out why the tests don't
work but why it works from sparkR shell. Its due to the fact we have two
different ways in whic
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115722800
Thanks @cafreeman for the update. I'll try this out today and see why
`run-tests.sh` is not picking it.
---
If your project is set up for it, you can reply to this ema
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115424026
[Test build #35810 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35810/consoleFull)
for PR 7001 at commit
[`0bea809`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115424063
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115391843
[Test build #35810 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35810/consoleFull)
for PR 7001 at commit
[`0bea809`](https://gith
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115391518
@shivaram Alright, I've uploaded a smaller JAR and switched to an absolute
filepath using SPARK_HOME. So far this test runs successfully in both the
sparkR shell and i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115391170
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115391144
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115359973
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115359932
[Test build #35798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35798/consoleFull)
for PR 7001 at commit
[`9a5c362`](https://git
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115358456
@cafreeman Regarding the test itself, a couple of things
1. Could we have a smaller JAR file ? This one looks like its around 5MB
which is pretty big :) Instead
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115337955
@cafreeman Created https://github.com/apache/spark/pull/7022 -- Could you
take a look at it ?
---
If your project is set up for it, you can reply to this email and hav
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115335693
@cafreeman The worrying thing is that the tests seem to pass right now on
Jenkins and on my machine if I run `./run-tests.sh` -- If you get a chance
it'll be good to fi
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115329193
Sorry the first one was a bug we introduced yesterday. Let me send a hotfix
for it right now
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115328504
[Test build #35798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35798/consoleFull)
for PR 7001 at commit
[`9a5c362`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115328152
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115328182
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115328026
@shivaram Just committed a first draft of a test, but there are two issues:
1. The current build appears to be broken. I'm getting issues about
sparkPackages being
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115306147
We could put it in in `R/pkg/inst/test_support` or something like that. It
would be similar to the python files at
https://github.com/apache/spark/tree/master/python/te
Github user sujkh85 commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115304990
NAVER - http://www.naver.com/
su...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼
ê°ì ì´ì ë¡ ì ì
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115304835
@shivaram where would we store test data? I have a JAR we could probably
use.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115092990
[Test build #35742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35742/consoleFull)
for PR 7001 at commit
[`5a80844`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115093010
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115067329
[Test build #35742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35742/consoleFull)
for PR 7001 at commit
[`5a80844`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115066308
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115066255
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115065662
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115065390
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115065369
[Test build #35738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35738/consoleFull)
for PR 7001 at commit
[`5a80844`](https://git
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115051075
@cafreeman Code change looks good -- I'm wondering if there is way to add a
test for this in SparkR. We could add a dummy jar file and then try and see if
we can call i
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115048691
[Test build #35738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35738/consoleFull)
for PR 7001 at commit
[`5a80844`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115048460
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115048446
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115048096
@shivaram Fixed style nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115040424
[Test build #35732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35732/consoleFull)
for PR 7001 at commit
[`7c6bd0c`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115040432
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115039975
[Test build #35732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35732/consoleFull)
for PR 7001 at commit
[`7c6bd0c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115039597
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115039558
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115037655
Jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115037618
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115037067
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7001#discussion_r33206314
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -88,6 +88,19 @@ private[r] class RBackendHandler(server: RBackend)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7001#discussion_r33206189
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -88,6 +88,19 @@ private[r] class RBackendHandler(server: RBackend)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7001#discussion_r33206168
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -88,6 +88,19 @@ private[r] class RBackendHandler(server: RBackend)
Github user cafreeman commented on the pull request:
https://github.com/apache/spark/pull/7001#issuecomment-115036379
JIRA issue open here: https://issues.apache.org/jira/browse/SPARK-8607
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user cafreeman opened a pull request:
https://github.com/apache/spark/pull/7001
[SPARK-8607] SparkR -- jars not being added to application classpath
correctly
Add `getStaticClass` method in SparkR's `RBackendHandler`
This is a fix for the problem referenced in
[SPAR
63 matches
Mail list logo
