[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115528323 merged this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r0034 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -363,6 +373,19 @@ object CatalystTypeConverters {

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115526785 LGTM, only one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r33329879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -363,6 +373,19 @@ object CatalystTypeConverters {

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115348864 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115348747 [Test build #35789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35789/console) for PR 7018 at commit [`8b16630`](https://github.

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115339536 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115339477 [Test build #35787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35787/console) for PR 7018 at commit [`326c82c`](https://github.

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115306229 [Test build #35789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35789/consoleFull) for PR 7018 at commit [`8b16630`](https://gith

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r33272591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala --- @@ -81,7 +81,7 @@ private[sql] object StatFunctions extends L

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115305986 cc @rxin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r33272562 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/stat/FrequentItems.scala --- @@ -90,7 +90,7 @@ private[sql] object FrequentItems extends L

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115305577 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115305604 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r33269907 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/TableScanSuite.scala --- @@ -88,9 +88,9 @@ case class AllDataTypesScan( UTF8Stri

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7018#discussion_r33269472 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -258,16 +273,13 @@ object CatalystTypeConverters {

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115298206 [Test build #35787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35787/consoleFull) for PR 7018 at commit [`326c82c`](https://gith

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115298005 the benchmark (ScalaUdf will convert from catalyst to scala and back again): ```scala case class Floor(child: Expression) extends UnaryExpression with Predicate

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115296917 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 이 다음과 같은 이유로 전ì†

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115296639 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115296578 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/7018 [SPARK-8635][SQL] improve performance of CatalystTypeConverters In `CatalystTypeConverters.createToCatalystConverter`, we add special handling for primitive types. We can apply this strategy to mo

[GitHub] spark pull request: [SPARK-8635][SQL] improve performance of Catal...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/7018#issuecomment-115295029 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 <[spark] [SPARK-8635][SQL] improve pe