[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-30 Thread litao-buptsse
Github user litao-buptsse closed the pull request at: https://github.com/apache/spark/pull/7053 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-116591124 [Test build #976 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/976/consoleFull) for PR 7053 at commit

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-116627120 [Test build #976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/976/console) for PR 7053 at commit

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-116541975 OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-115975997 [Test build #967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/967/console) for PR 7053 at commit

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-27 Thread litao-buptsse
Github user litao-buptsse commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-115977907 Some unit tests failed. I will review my PR code again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-27 Thread litao-buptsse
Github user litao-buptsse commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-116045509 @srowen I think maybe the first fs param in addResource() is needed, especially it's useful when doing unit test. I see the ClientDistributedCacheManagerSuite

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-27 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/7053#discussion_r33418320 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -322,7 +322,7 @@ private[spark] class Client(

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-115942642 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-26 Thread litao-buptsse
GitHub user litao-buptsse opened a pull request: https://github.com/apache/spark/pull/7053 [SPARK-8657] [YARN] Simplify method addResource() and get the correct fs from destPath. [SPARK-8657] [YARN] Simplify method addResource() and get the correct fs from destPath. JIRA

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-115962588 OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8657] [YARN] Simplify method addResourc...

2015-06-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7053#issuecomment-115962680 [Test build #967 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/967/consoleFull) for PR 7053 at commit