Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-219818786
[Test build #58715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58715/consoleFull)
for PR 7075 at commit
[`feacda0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-219855097
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-219854991
[Test build #58715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58715/console)
for PR 7075 at commit
[`feacda0`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-219855099
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-126148990
@sryza Do you want to make another pass? Please sign off if you think this
is ready:)
---
If your project is set up for it, you can reply to this email and have your
rep
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939346
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939406
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
---
@@ -196,4 +196,18 @@ object Statistics {
: KolmogorovSmirnovTestResult
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939466
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939524
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939544
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939624
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939648
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939695
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939722
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939785
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939844
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTest
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939884
--- Diff: docs/mllib-statistics.md ---
@@ -431,11 +431,16 @@ user tests against the normal distribution
(`distName="norm"`), but does not pro
parameters, t
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35939958
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFunSuite w
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-126536916
@mengxr @josepablocam oops thought it was still a WIP for some reason.
Just took a pass. It looks mostly done - I just had a bunch of nits and a test
request.
---
If
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35942130
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmir
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35942456
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmir
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35942574
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmir
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35943124
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmir
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35943216
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFun
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35943432
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFun
Github user josepablocam commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-126563356
Mmm. I seem to be having some issues building and testing on my laptop. It
keeps failing when building Catalyst. I'll try this first thing in the morning
at work an
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35951035
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTes
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35951096
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTes
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r35951155
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,93 @@ private[stat] object KolmogorovSmirnovTes
GitHub user josepablocam opened a pull request:
https://github.com/apache/spark/pull/7075
[SPARK-8674] [MLlib] Implementation of a 2 sample Kolmogorov Smirnov Test
The current patch implements a 2-sample, 2-sided Kolmogorov Smirnov test.
Similarly to the 1-sample implementation, we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-116330605
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-119297378
So this isn't to be merged in its current form? Put `[WIP]` in the title.
This should probably just be reviewed later if/when the other PR is merged.
---
If your project
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125136
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -254,4 +254,115 @@ class HypothesisTestSuite extends SparkFunSuite w
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125365
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -53,6 +53,7 @@ private[stat] object KolmogorovSmirnovTest ex
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125839
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,104 @@ private[stat] object KolmogorovSmirnovTes
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36125885
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,104 @@ private[stat] object KolmogorovSmirnovTes
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36126317
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,104 @@ private[stat] object KolmogorovSmirnovTes
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36147712
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -53,6 +53,7 @@ private[stat] object KolmogorovSmirnov
Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7075#discussion_r36148400
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/KolmogorovSmirnovTest.scala
---
@@ -190,5 +191,104 @@ private[stat] object KolmogorovSmi
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-127758313
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-127758361
This LGTM pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128030535
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128030890
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128068049
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128068926
[Test build #39872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39872/consoleFull)
for PR 7075 at commit
[`16ba96e`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128089746
[Test build #39872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39872/console)
for PR 7075 at commit
[`16ba96e`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128089813
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user josepablocam commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-128090563
ugh, did not reword the tests in pyspark after we slightly cleaned up the
grammar in the 2 sample test. I will make the ks 2 sample test hypothesis
statement match
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-131819801
@mengxr is it too late to get this in to 1.5?
@josepablocam are you able to resolve merge conflicts?
---
If your project is set up for it, you can reply to this e
Github user josepablocam commented on the pull request:
https://github.com/apache/spark/pull/7075#issuecomment-131920956
@sryza fixed merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
51 matches
Mail list logo
