[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-03 Thread ilganeli
Github user ilganeli closed the pull request at: https://github.com/apache/spark/pull/7160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-02 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-118211797 Will do once I have access to a PC. No trouble at all. Thank you, Ilya Ganelin -Original Message- From: jkbradley [n

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-118188231 OK, sorry for the trouble! Can you please close this PR? (We can't) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-02 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-118187601 All - thanks for the clarification and weigh in. I don't have any pipelines set up that would exercise this with the level of rigor necessary. I think it's fine to clos

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-118181016 Good points; I suppose unpersisting without blocking might cause other slowdowns which could cause other timeouts to occur. This does seem like the kind of change whi

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-118168599 I think the concern is that the memory cache is not fully LRU. If a new big block shows up when the memory cache is almost full, then there's a chance that the new bl

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117792531 @mengxr @jkbradley Initially reported this, perhaps he should weigh in here? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117785223 @ilganeli I'm not sure whether this is a safe change. If the old ones are not deleted from block managers, new RDDs might not be able to cache or have to downgrade the st

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117727391 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117727171 [Test build #36273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36273/console) for PR 7160 at commit [`d976187`](https://github.

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117713158 [Test build #36273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36273/consoleFull) for PR 7160 at commit [`d976187`](https://gith

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117712904 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117712925 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117711399 [Test build #36272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36272/console) for PR 7160 at commit [`381dc42`](https://github.

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117711407 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117710404 [Test build #36272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36272/consoleFull) for PR 7160 at commit [`381dc42`](https://gith

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117709446 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117709485 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117709470 [Test build #36269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36269/console) for PR 7160 at commit [`f31f0c1`](https://github.

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117709407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread ilganeli
GitHub user ilganeli opened a pull request: https://github.com/apache/spark/pull/7160 [SPARK-8733][MLLIB] ML RDD.unpersist calls should use blocking = false Updated all usages within the ML Lib module to use blocking = false. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117708446 [Test build #36269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36269/consoleFull) for PR 7160 at commit [`f31f0c1`](https://gith

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117708318 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8733][MLLIB] ML RDD.unpersist calls sho...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7160#issuecomment-117708283 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h