[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-12 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/7364 [SPARK-8761][Deploy]Added synchronization in removeApplication Master.removeApplication is not thread-safe. But it's called both in the message loop of Master and MasterPage.handleAppKillRequest whi

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7364#issuecomment-120822743 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7364#discussion_r34446919 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -727,40 +727,44 @@ private[master] class Master( def removeApplic

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7364#issuecomment-121070286 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-13 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/7364#discussion_r34534208 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -727,40 +727,44 @@ private[master] class Master( def removeAppli

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7364#discussion_r34541643 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -727,40 +727,44 @@ private[master] class Master( def removeApplic

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-14 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/7364#issuecomment-121303647 Closing this incomplete PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-8761][Deploy]Added synchronization in r...

2015-07-14 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/spark/pull/7364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena