Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-120056881
@tarekauel Yes, we can remove that. I will do that while merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119874411
[Test build #1019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1019/console)
for PR 7236 at commit
[`ee4c4de`](https://github
Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119866434
@davies One question regarding the comment in line 103 of `numChars`:
```This is only used by Substring() when `start` is negative.``` Can I just
remove this comment o
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34231566
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,70 @@ public boolean equals(final Object other) {
}
Github user HuJiayin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34229711
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,70 @@ public boolean equals(final Object other) {
}
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119840066
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119839695
[Test build #1019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1019/consoleFull)
for PR 7236 at commit
[`ee4c4de`](https://git
Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119839244
Can someone help with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119823089
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119823054
[Test build #36893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36893/console)
for PR 7236 at commit
[`ee4c4de`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119821426
[Test build #36893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36893/consoleFull)
for PR 7236 at commit
[`ee4c4de`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119821323
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119821332
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119820936
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119820714
@davies thanks for your feedback. Can someone trigger Jenkins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223429
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223385
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223281
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223256
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223208
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34223127
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34222698
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -254,6 +254,67 @@ public boolean equals(final Object other) {
}
Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119813214
@rxin I just did it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-119812439
@tarekauel can you bring this up to date?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r34005887
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33995493
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33977342
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-118968258
cc @davies can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33978781
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33981013
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33977873
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33977790
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33977682
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7236#discussion_r33977540
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -207,6 +207,78 @@ public boolean equals(final Object other) {
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7236#issuecomment-118780400
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user tarekauel opened a pull request:
https://github.com/apache/spark/pull/7236
[SPARK-8830][SQL] native levenshtein distance
Jira: https://issues.apache.org/jira/browse/SPARK-8830
@rxin and @HuJiayin can you have a look on it.
You can merge this pull request into a
37 matches
Mail list logo
