[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121420487 Thanks - merging this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121418227 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121417844 [Test build #37260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37260/console) for PR 7350 at commit [`e3e96f7`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121381387 [Test build #37260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37260/consoleFull) for PR 7350 at commit [`e3e96f7`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121379789 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121379767 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121379120 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121373176 [Test build #37247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37247/console) for PR 7350 at commit [`e3e96f7`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121373248 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121337560 [Test build #37247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37247/consoleFull) for PR 7350 at commit [`e3e96f7`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121337341 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121337371 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121336363 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121336278 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121329711 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121329686 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121329440 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121139541 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121139518 [Test build #37190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37190/console) for PR 7350 at commit [`e3e96f7`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121126447 [Test build #37190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37190/consoleFull) for PR 7350 at commit [`e3e96f7`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121126323 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121126339 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121125601 Argh... will fix now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121124222 Unfortunately another pr created a conflict again ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121110144 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121110098 [Test build #37159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37159/console) for PR 7350 at commit [`c0b7885`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121092048 [Test build #37159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37159/consoleFull) for PR 7350 at commit [`c0b7885`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121091581 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121091603 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121088938 [Test build #37158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37158/console) for PR 7350 at commit [`d707ba7`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121088943 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121087535 [Test build #37158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37158/consoleFull) for PR 7350 at commit [`d707ba7`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121087365 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121087346 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-121070408 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120832312 [Test build #1053 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1053/console) for PR 7350 at commit [`62882ee`](https://github

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120830561 [Test build #1053 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1053/consoleFull) for PR 7350 at commit [`62882ee`](https://git

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120792014 @JoshRosen looks like you missed a few places. Can you fix them so we can merge this? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120754733 @shivaram, in this case I think the style rule is justified even if it's inconvenient or a hassle to implmenet because this `Class.forName` issue has led to a number o

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-11 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120649066 The RBackendHandler change looks good to me. I do find it weird that we have scala style rules for not using specific functions, but I guess its hard to track this duri

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120551362 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120551361 [Test build #37065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37065/console) for PR 7350 at commit [`62882ee`](https://github.

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120551193 [Test build #37065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37065/consoleFull) for PR 7350 at commit [`62882ee`](https://gith

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120551097 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120551076 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120550801 /cc @yhuai @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7350#issuecomment-120550864 This pull request might become intractable to review due to how many files it touches, so I recommend using the Reviewable link to keep track of changes. --- If your

[GitHub] spark pull request: [SPARK-8962] Add Scalastyle rule to ban direct...

2015-07-10 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/7350 [SPARK-8962] Add Scalastyle rule to ban direct use of Class.forName; fix existing uses This pull request adds a Scalastyle regex rule which fails the style check if `Class.forName` is used direct