Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-165532682
To add my two cents, I think that to call this change "cosmetic" is
strictly true but underrates its value. In our case we have additional
monitoring systems that
Github user mallman commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-165559632
@andrewor14 We've put this in production. Everything looks good. Hostnames
show up in the UI as expected. No broken links.
---
If your project is set up for it, you
Github user bdzimmer commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-165584437
@mallman I'm glad this was useful to someone! I didn't have the time (and
probably won't in the future) to look into the refactoring that @nyaapa
suggested back in
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-164607194
What's the resolution on this? If possible I would prefer a small change
that doesn't require refactoring or introducing the flag. What are some
side-effects of this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-158549442
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nyaapa commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-143269671
*let me remind you about this discussion and ipv6 support at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-126453301
[Test build #39074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39074/console)
for PR 7345 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-126453579
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-126409418
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-126409449
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-126410477
[Test build #39074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39074/consoleFull)
for PR 7345 at commit
Github user bdzimmer commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122299160
What about an optional command line argument to start-slaves.sh /
start-slave.sh that would enable using `hostname -f`? Or an environment
variable? That way IP
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122346519
A flag to set the flag? no, callers can always specify `--host` directly.
Yeah the problem is we are weighing a cosmetic, but legitimate, improvement
over something that
Github user bdzimmer commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122372502
start-slave.sh and slaves.sh pass through all of their args. But
start-slaves.sh does not:
```sh
$sbin/slaves.sh cd $SPARK_HOME \; $sbin/start-slave.sh
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122383737
I take your point yeah, nevermind me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bdzimmer commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122364108
You definitely specify `--host` if you are calling start-slave.sh directly.
But start-slaves.sh invokes the same command for each slave.
---
If your project is set up
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122370258
Yes, but you can right? it passes through all the script's args. I thought
you were suggesting adding a flag to the slave script, when it can basically
already accept
Github user nyaapa commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122390631
What if we try to do some refactoring?
1) we need to clean up some old code with ipv4:port hardcoded
http://pastebin.com/eJvR1sA4
2) after that we can remove
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-122155397
I tried this out locally and was able to see the difference. I do remember
that we used to have host names there instead of IP addresses. I think this is
a good
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121033507
[Test build #37142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37142/console)
for PR 7345 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121033584
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121001118
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121001146
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121001771
[Test build #37142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37142/consoleFull)
for PR 7345 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-121070465
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bdzimmer opened a pull request:
https://github.com/apache/spark/pull/7345
[SPARK-8982][Core] Worker hostnames not showing in Master web ui when
launched with start-slaves.sh
If a --host argument is not provided to Worker, WorkerArguments uses
Utils.localHostName to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120483401
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120509675
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120509791
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120509814
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120510435
[Test build #37054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37054/consoleFull)
for PR 7345 at commit
Github user bdzimmer commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120533209
I was just surprised when I started up a standalone mode Spark 1.4.0
cluster for the first time (with similar configuration as I've used in the past
with Spark 1.0 -
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120515636
Hm, I only sort of understand the entirety of the logic, but
`Utils.localHostName` is what a lot of stuff consults to know what the local
host is, and the logic does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120540453
[Test build #37054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37054/console)
for PR 7345 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7345#issuecomment-120540531
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
35 matches
Mail list logo
