[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-10 Thread tarekauel
GitHub user tarekauel opened a pull request: https://github.com/apache/spark/pull/7353 [SPARK-8995][SQL] cast date strings like '2015-01-01 12:15:31' to date Jira https://issues.apache.org/jira/browse/SPARK-8995 In PR #6981we noticed that we cannot cast date strings that con

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120564749 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120593192 This was by intentional as hive doesn't support it. However, our new design about [date time](https://issues.apache.org/jira/secure/attachment/12743900/SparkSQLdatetim

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-11 Thread tarekauel
Github user tarekauel commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120637117 Okay, yes I'm going to extend it. What Hive does support is parsing the minute from `13:20:08`. Our minute method requires a TimeStamp. Either we don't support the `mi

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-11 Thread tarekauel
Github user tarekauel commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120668526 @cloud-fan The following strings can be parsed now: (String --> Date) ``, `-[m]m`, `-[m]m-[d]d`, `-[m]m-[d]d `, `-[m]m-[d]d *`, `-[m]m-

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120814044 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120814494 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120814489 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120814560 [Test build #37124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37124/consoleFull) for PR 7353 at commit [`71f89c1`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120818700 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120818668 [Test build #37124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37124/console) for PR 7353 at commit [`71f89c1`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120830502 [Test build #1051 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1051/consoleFull) for PR 7353 at commit [`71f89c1`](https://git

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120835078 [Test build #1051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1051/console) for PR 7353 at commit [`71f89c1`](https://github

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120839854 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120839860 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120840024 [Test build #37129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37129/consoleFull) for PR 7353 at commit [`cfbaed7`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120858846 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120858820 [Test build #37129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37129/console) for PR 7353 at commit [`cfbaed7`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-120945974 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34485123 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486447 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34487639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486376 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34487132 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486104 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486393 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34488268 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34488087 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34487892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34484474 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,15 +165,8 @@ case class Cast(child: Expression, dataTyp

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121000987 @tarekauel Thanks for working on this, it's in a good shape, just a few comments. As you mentioned in the description, `18:03:20` could be parsed as timestamp, b

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34486426 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -165,15 +165,8 @@ case class Cast(child: Expression, data

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34490284 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121007809 @davies thanks for all your good comments. I'm going to incorporate your suggestions. I don't accept `18:03:20` , yet. The design document doesn't allow this.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121070377 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34521930 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34522270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34523735 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34523785 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34523798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34524098 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121105077 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121105084 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121102839 [Test build #37168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37168/console) for PR 7353 at commit [`71622c0`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121102638 [Test build #37168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37168/consoleFull) for PR 7353 at commit [`71622c0`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121102842 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121102108 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34526036 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121102132 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34527437 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121105407 [Test build #37171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37171/consoleFull) for PR 7353 at commit [`34ec573`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121115327 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121115312 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121115629 [Test build #37177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37177/consoleFull) for PR 7353 at commit [`01c9ff3`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121115835 [Test build #37171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37171/console) for PR 7353 at commit [`34ec573`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121115853 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread tarekauel
Github user tarekauel commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121118086 @davies How should we deal with this? I don't know the value of `'value`, but it seems to be something that the parser can parse can be parsed to `1.1.1970`.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121127643 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121127629 [Test build #37177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37177/console) for PR 7353 at commit [`01c9ff3`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121682853 In master, we can't cast `'238'` as timestamp, ``` spark-sql> select DATEDIFF(CAST(238 AS timestamp), CAST('2002-03-21 00:00:00' AS timestamp)); -11767 Tim

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121691127 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121691146 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121694661 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread tarekauel
Github user tarekauel commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121697293 @davies somehow Jenkins wasn't able to fetch from GitHub. Could you trigger Jenkins, again? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121706449 [Test build #1075 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1075/consoleFull) for PR 7353 at commit [`ef05753`](https://git

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121712861 [Test build #1075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1075/console) for PR 7353 at commit [`ef05753`](https://github

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121762926 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121762982 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121763808 [Test build #37415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37415/consoleFull) for PR 7353 at commit [`d20b8b4`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121776695 [Test build #37415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37415/console) for PR 7353 at commit [`d20b8b4`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121776785 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34742916 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,169 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121816920 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121816935 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121817328 [Test build #37454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37454/consoleFull) for PR 7353 at commit [`ca1ae69`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121830665 [Test build #37454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37454/console) for PR 7353 at commit [`ca1ae69`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121830731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34758673 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -86,4 +88,198 @@ class DateTimeUtilsSuite extends Spa

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34758993 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34759109 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34759205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121846456 LGTM, just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34761324 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121865724 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121865673 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34762666 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121866540 [Test build #37476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37476/consoleFull) for PR 7353 at commit [`14f333b`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121890316 [Test build #37476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37476/console) for PR 7353 at commit [`14f333b`](https://github.

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121890622 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121992758 Thanks for the update, merging this into master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab