[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread zhangjiajin
GitHub user zhangjiajin opened a pull request: https://github.com/apache/spark/pull/7383 [SPARK-8998][MLlib] Collect enough frequent prefixes before projection in PrefixSpan Add feature: Collect enough frequent prefixes before projection in PrefixSpan. You can merge this pull requ

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121115302 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121115323 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121115570 [Test build #37175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37175/consoleFull) for PR 7383 at commit [`22b0ef4`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121115712 [Test build #37175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37175/console) for PR 7383 at commit [`22b0ef4`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121115715 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121116140 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121116147 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121116235 [Test build #37178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37178/consoleFull) for PR 7383 at commit [`078d410`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121132582 [Test build #37178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37178/console) for PR 7383 at commit [`078d410`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121132703 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121149967 @mengxr This PR includes the previous PR. Maybe the previous PR have not be properly closed. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121372650 The Apache GitHub is out of sync. You can try to close this PR and re-open it. It might help. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121372804 Btw, you shouldn't work directly on your master branch. Instead, you should create a separate branch for each issue, and send pull request from that branch. --- If your

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
GitHub user zhangjiajin reopened a pull request: https://github.com/apache/spark/pull/7383 [SPARK-8998][MLlib] Collect enough frequent prefixes before projection in PrefixSpan Add feature: Collect enough frequent prefixes before projection in PrefixSpan. You can merge this pull re

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin closed the pull request at: https://github.com/apache/spark/pull/7383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin closed the pull request at: https://github.com/apache/spark/pull/7383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
GitHub user zhangjiajin reopened a pull request: https://github.com/apache/spark/pull/7383 [SPARK-8998][MLlib] Collect enough frequent prefixes before projection in PrefixSpan Add feature: Collect enough frequent prefixes before projection in PrefixSpan. You can merge this pull re

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121437173 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121437166 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121437541 [Test build #37288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37288/consoleFull) for PR 7383 at commit [`078d410`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin closed the pull request at: https://github.com/apache/spark/pull/7383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121470734 [Test build #37288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37288/console) for PR 7383 at commit [`078d410`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121470785 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
GitHub user zhangjiajin reopened a pull request: https://github.com/apache/spark/pull/7383 [SPARK-8998][MLlib] Collect enough frequent prefixes before projection in PrefixSpan Add feature: Collect enough frequent prefixes before projection in PrefixSpan. You can merge this pull re

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121477915 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121477909 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121478300 @zhangjiajin Let's close this PR and re-submit a PR from a different branch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121478284 [Test build #37308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37308/consoleFull) for PR 7383 at commit [`a8fde87`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121478653 @mengxr OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin closed the pull request at: https://github.com/apache/spark/pull/7383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121478711 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
GitHub user zhangjiajin opened a pull request: https://github.com/apache/spark/pull/7412 [SPARK-8998][MLlib] Collect enough frequent prefixes before projection in PrefixSpan (new) Collect enough frequent prefixes before projection in PrefixSpan You can merge this pull request into

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121478722 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121479591 [Test build #37309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37309/consoleFull) for PR 7412 at commit [`6560c69`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121480109 @mengxr This is new PR, please review it. TKS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121483985 cc @feynmanliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121484492 [Test build #37309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37309/console) for PR 7412 at commit [`6560c69`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121484523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34647725 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121499020 [Test build #37308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37308/console) for PR 7383 at commit [`a8fde87`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7383#issuecomment-121499068 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648292 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648317 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648512 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648644 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648882 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648856 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34648954 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649006 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649027 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649022 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649034 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649059 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649375 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34649591 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121508184 * PR title is off; should be "before local processing" instead of "before projection" * Instead of terminating on `minPatternsBeforeShuffle`, should the termin

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121508191 That's all for now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34650374 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-14 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34650468 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34650625 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34650635 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34650869 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34652091 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34652339 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34652323 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34652312 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34653266 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34657699 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34657764 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCou

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121533978 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121533928 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121534535 [Test build #37344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37344/consoleFull) for PR 7412 at commit [`baa2885`](https://gith

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121547899 [Test build #37344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37344/console) for PR 7412 at commit [`baa2885`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121548060 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121557045 @feynmanliang If we want get the size of projected database, we must group by the prefix and suffix pairs. When the prefix length is small, and sequences are very lo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34731695 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34731654 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34731833 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34732328 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34733098 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -86,16 +88,69 @@ class PrefixSpan private ( getFreqItemAndCo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34733453 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34733403 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121762995 My concern is not projected database > # patterns, rather it is that the `groupByKey` on L103 will overload an executor if some key (prefix) has many values (suffix

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34735567 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34735768 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34735693 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34736431 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34736588 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34736608 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34736797 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34737011 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Inpu

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34737026 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -43,6 +43,8 @@ class PrefixSpan private ( private var minSuppo

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745070 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -43,6 +43,8 @@ class PrefixSpan private ( private var minSuppor

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745105 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745193 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745225 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745262 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745388 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread zhangjiajin
Github user zhangjiajin commented on a diff in the pull request: https://github.com/apache/spark/pull/7412#discussion_r34745701 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -82,20 +84,70 @@ class PrefixSpan private ( logWarning("Input

  1   2   >