GitHub user jendap opened a pull request:
https://github.com/apache/spark/pull/7375
[SPARK-9015] [BUILD] Clean project import in scala ide
Cleanup maven for a clean import in scala-ide / eclipse.
* remove groovy plugin which is really not needed at all
* add-source from
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-120999013
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121000316
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34491750
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34492125
--- Diff: pom.xml ---
@@ -1406,6 +1382,59 @@
maven-deploy-plugin
2.8.2
+
+
+
+
+ or
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34492161
--- Diff: pom.xml ---
@@ -1423,34 +1452,12 @@
test
- ${test_classpath_file}
+
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34492757
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34493332
--- Diff: tools/pom.xml ---
@@ -76,10 +76,6 @@
org.apache.maven.plugins
maven-source-plugin
-
--- End diff -
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34493381
--- Diff: sql/hive/pom.xml ---
@@ -133,7 +133,6 @@
-src/test/scala
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34493238
--- Diff: pom.xml ---
@@ -1406,6 +1382,59 @@
maven-deploy-plugin
2.8.2
+
+
+
+
+ or
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34493513
--- Diff: pom.xml ---
@@ -1518,36 +1525,6 @@
maven-enforcer-plugin
-org.codehaus.mojo
--- End diff --
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34493745
--- Diff: pom.xml ---
@@ -1423,34 +1452,12 @@
test
- ${test_classpath_file}
+
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34494442
--- Diff: pom.xml ---
@@ -1406,6 +1382,59 @@
maven-deploy-plugin
2.8.2
+
+
+
+
+ or
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34494500
--- Diff: pom.xml ---
@@ -1518,36 +1525,6 @@
maven-enforcer-plugin
-org.codehaus.mojo
--- End diff --
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34495519
--- Diff: pom.xml ---
@@ -1423,34 +1452,12 @@
test
- ${test_classpath_file}
+
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34495655
--- Diff: pom.xml ---
@@ -1518,36 +1525,6 @@
maven-enforcer-plugin
-org.codehaus.mojo
--- End diff --
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121017656
[Test build #1059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1059/consoleFull)
for PR 7375 at commit
[`312007e`](https://git
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34496608
--- Diff: pom.xml ---
@@ -1406,6 +1382,59 @@
maven-deploy-plugin
2.8.2
+
+
+
+
+ or
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34496993
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34497039
--- Diff: pom.xml ---
@@ -1406,6 +1382,59 @@
maven-deploy-plugin
2.8.2
+
+
+
+
+ or
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34497201
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121022250
I have double checked all this with "mvn install". It generates exactly the
same output in local repo - bit by bit - with exception of the pom xml and
property files in M
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34498770
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34499093
--- Diff: sql/hive/pom.xml ---
@@ -133,7 +133,6 @@
-src/test/scal
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34499119
--- Diff: sql/hive/pom.xml ---
@@ -133,7 +133,6 @@
-src/test/scal
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34500353
--- Diff: sql/hive/pom.xml ---
@@ -133,7 +133,6 @@
-src/test/scala
Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34502106
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121047661
[Test build #1059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1059/console)
for PR 7375 at commit
[`312007e`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121070218
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34537727
--- Diff: pom.xml ---
@@ -1423,34 +1452,12 @@
test
- ${test_classpath_file}
+
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34541288
--- Diff: pom.xml ---
@@ -319,17 +306,6 @@
1.0.0
-
--- End diff --
Note that removing this from the depen
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121149951
This is looking good, though I'm still skeptical about the Eclipse
addition. Does it work, but just shows a spurious error when opening the
project the first time? then t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121150322
[Test build #1063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1063/consoleFull)
for PR 7375 at commit
[`5a83e07`](https://git
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121159798
It does work without lifecycle-mapping but it shows errors. Not just after
import but all the way until you resolve them.
It is not needed. On the other hand it m
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121160249
It's a fair argument. I also think the build is horribly complex enough
already and would like to simplify at all costs. Does anyone else have any
strong opinion on this?
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121165242
I can see you do not want to add any extra line to the pom file :-) I think
the build should primary work. Batteries included. For that reason we should
merge the lifecyc
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121166468
The change-version scripts are being improved in SPARK-8401. Still ugly,
but I'm not sure we have a better way given how Maven works and how Scala
artifact conventions un
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121170538
None of those are part of this PR. We should take that discussion elsewhere.
BTW: I have a prototype solving the artifactId conventions inside maven.
Integrations
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121171688
Yeah side discussions. The encrypted file system thing is really an
end-user env limitation and not something the build is going to work around --
this was discussed earl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121173817
[Test build #1063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1063/console)
for PR 7375 at commit
[`5a83e07`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121174469
[Test build #1065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1065/consoleFull)
for PR 7375 at commit
[`5a83e07`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121178034
[Test build #1065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1065/console)
for PR 7375 at commit
[`5a83e07`](https://github
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121340118
@srowen do you understand what is going on with the builds? 3 failed builds
is pretty convincing argument something is not ok. But looking at their output
- 3 build 3 dif
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121348904
Yeah, I was wondering the same. The first two might have been spurious; the
last is more 'convincing' but I don't get how the build would not have hit this
the first time
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121349106
[Test build #1066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1066/consoleFull)
for PR 7375 at commit
[`5a83e07`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121397532
[Test build #1066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1066/console)
for PR 7375 at commit
[`5a83e07`](https://github
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121604431
Passes now. Well, let's leave in the eclipse bit. It's still a net
simplification. There is one very trivial whitespace issue -- think you have
tab instead of spaces on
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-121709635
Sure! Whitespaces are fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jendap commented on the pull request:
https://github.com/apache/spark/pull/7375#issuecomment-122036687
thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
50 matches
Mail list logo
